public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed

From: Cyril Strejc <strejc@unicontrols•cz>
To: linuxppc-dev@lists•ozlabs.org
Subject: mpc5200b: invalid IRQ
Date: Thu, 12 Apr 2012 13:41:56 +0200	[thread overview]
Message-ID: <4F86BF84.1050107@unicontrols.cz> (raw)

Hi,

I've just tried to boot 2.6.32, 3.0 and mainline kernel on my mpc5200b 
based board, on 3.0 and mainline resulting in

mpc52xx_irqhost_map: invalid irq: virq=16, l1=0, l2=3

The device tree is based on mpc5200b.dtsi, hence the invalid irq comes from

gpio_wkup: gpio@c00 {
      ...
      interrupts = <1 8 0 0 3 0>;
      ...
};

Being new in the kernel powerpc internals, I've found, that in the 
kernel 2.6.32 interrupts section has no generic meaning and specific 
device driver should handle it itself. Since commit 
ac80a51e2ce5c431de9997085f33cb6093218b1f (of/device: populate 
platform_device (of_device) resource table on allocation) interrupts 
section is handled by of_device_alloc and irq mapping is done regardless 
of specific device driver.

In 2.6.32, gpio_wkup interrupts section was unused in my case, so never 
had a problem. Since the commit, mpc5200-pic driver is asked to make a 
mapping during platform bus initialization resulting in the "invalid 
irq" error.

There are four critical interrupts on MPC5200b, but only IRQ[0] critical 
interrupt is handled by mpc5200-pic driver, the others, like WakeUp from 
deep-sleep mode (CCS) interrupt (my case) are not.

I do not need WakeUp interrupt and I think I can simply remove gpio_wkup 
interrupts section from the device tree, but I would like to ask you, 
what does it mean. If it is mpc5200-pic driver's incompleteness or some 
other error.

Thanks.

Cyril Strejc

                 reply	other threads:[~2012-04-12 11:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F86BF84.1050107@unicontrols.cz \
    --to=strejc@unicontrols$(echo .)cz \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox