From: Sergei Shtylyov <sshtylyov@mvista•com>
To: "Thang Q. Nguyen" <tqnguyen@apm•com>
Cc: Phong Vo <pvo@apm•com>,
devicetree-discuss@lists•ozlabs.org,
linuxppc-dev@lists•ozlabs.org,
Rob Herring <rob.herring@calxeda•com>,
linux-kernel@vger•kernel.org, linux-ide@vger•kernel.org,
Paul Mackerras <paulus@samba•org>,
Jeff Garzik <jgarzik@pobox•com>
Subject: Re: [PATCH 1/7] Add support hardreset
Date: Tue, 17 Apr 2012 15:06:20 +0400 [thread overview]
Message-ID: <4F8D4EAC.1010301@mvista.com> (raw)
In-Reply-To: <1334652193-10487-1-git-send-email-tqnguyen@apm.com>
Hello.
On 17-04-2012 12:43, Thang Q. Nguyen wrote:
> The hardreset operation is currently not supported. This causes sometime the SATA driver does cause kernel crash because of none-determined state.a This patch will fix the issue.
> Signed-off-by: Thang Q. Nguyen<tqnguyen@apm•com>
> ---
> drivers/ata/sata_dwc_460ex.c | 24 +++++++++++++++++++++++-
> 1 files changed, 23 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
> index 69f7cde..ae13ef1 100644
> --- a/drivers/ata/sata_dwc_460ex.c
> +++ b/drivers/ata/sata_dwc_460ex.c
> @@ -1581,10 +1581,31 @@ static void sata_dwc_qc_prep(struct ata_queued_cmd *qc)
>
> static void sata_dwc_error_handler(struct ata_port *ap)
> {
> - ap->link.flags |= ATA_LFLAG_NO_HRST;
> ata_sff_error_handler(ap);
> }
Could eliminate this, switching to the default implementation...
MBR, Sergei
prev parent reply other threads:[~2012-04-17 11:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 8:43 [PATCH 1/7] Add support hardreset Thang Q. Nguyen
2012-04-17 11:06 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8D4EAC.1010301@mvista.com \
--to=sshtylyov@mvista$(echo .)com \
--cc=devicetree-discuss@lists$(echo .)ozlabs.org \
--cc=jgarzik@pobox$(echo .)com \
--cc=linux-ide@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=pvo@apm$(echo .)com \
--cc=rob.herring@calxeda$(echo .)com \
--cc=tqnguyen@apm$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox