From: David Daney <ddaney.cavm@gmail•com>
To: "Srivatsa S. Bhat" <srivatsa.bhat@linux•vnet.ibm.com>
Cc: Venkatesh Pallipadi <venki@google•com>,
Jeremy Fitzhardinge <jeremy@goop•org>,
linux-ia64@vger•kernel.org, linux-mips@linux-mips•org,
peterz@infradead•org, linux-kernel@vger•kernel.org,
"H. Peter Anvin" <hpa@zytor•com>,
mingo@kernel•org, linux-arch@vger•kernel.org,
xen-devel@lists•xensource.com,
Suresh Siddha <suresh.b.siddha@intel•com>,
linux-sh@vger•kernel.org, x86@kernel•org,
Ingo Molnar <mingo@redhat•com>,
paulmck@linux•vnet.ibm.com, Fenghua Yu <fenghua.yu@intel•com>,
Mike Frysinger <vapier@gentoo•org>,
Peter Zijlstra <a.p.zijlstra@chello•nl>,
nikunj@linux•vnet.ibm.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>,
rusty@rustcorp•com.au, Chris Metcalf <cmetcalf@tilera•com>,
rjw@sisk•pl, yong.zhang0@gmail•com, tglx@linutronix•de,
virtualization@lists•linux-foundation.org,
Tony Luck <tony.luck@intel•com>,
vatsa@linux•vnet.ibm.com, Ralf Baechle <ralf@linux-mips•org>,
Paul Mundt <lethal@linux-sh•org>,
akpm@linux-foundation•org, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 03/27] smpboot: Define and use cpu_state per-cpu variable in generic code
Date: Fri, 01 Jun 2012 09:59:07 -0700 [thread overview]
Message-ID: <4FC8F4DB.2070906@gmail.com> (raw)
In-Reply-To: <20120601091038.31979.67878.stgit@srivatsabhat.in.ibm.com>
On 06/01/2012 02:10 AM, Srivatsa S. Bhat wrote:
> The per-cpu variable cpu_state is used in x86 and also used in other
> architectures, to track the state of the cpu during bringup and hotplug.
> Pull it out into generic code.
>
> Cc: Tony Luck<tony.luck@intel•com>
> Cc: Fenghua Yu<fenghua.yu@intel•com>
> Cc: Ralf Baechle<ralf@linux-mips•org>
> Cc: Benjamin Herrenschmidt<benh@kernel•crashing.org>
> Cc: Paul Mundt<lethal@linux-sh•org>
> Cc: Chris Metcalf<cmetcalf@tilera•com>
> Cc: Thomas Gleixner<tglx@linutronix•de>
> Cc: Ingo Molnar<mingo@redhat•com>
> Cc: "H. Peter Anvin"<hpa@zytor•com>
> Cc: x86@kernel•org
> Cc: Konrad Rzeszutek Wilk<konrad.wilk@oracle•com>
> Cc: Jeremy Fitzhardinge<jeremy@goop•org>
> Cc: Peter Zijlstra<a.p.zijlstra@chello•nl>
> Cc: Andrew Morton<akpm@linux-foundation•org>
> Cc: Mike Frysinger<vapier@gentoo•org>
> Cc: Yong Zhang<yong.zhang0@gmail•com>
> Cc: Venkatesh Pallipadi<venki@google•com>
> Cc: Suresh Siddha<suresh.b.siddha@intel•com>
> Cc: linux-ia64@vger•kernel.org
> Cc: linux-mips@linux-mips•org
> Cc: linuxppc-dev@lists•ozlabs.org
> Cc: linux-sh@vger•kernel.org
> Cc: xen-devel@lists•xensource.com
> Cc: virtualization@lists•linux-foundation.org
> Signed-off-by: Srivatsa S. Bhat<srivatsa.bhat@linux•vnet.ibm.com>
> ---
>
> arch/ia64/include/asm/cpu.h | 2 --
> arch/ia64/kernel/process.c | 1 +
> arch/ia64/kernel/smpboot.c | 6 +-----
> arch/mips/cavium-octeon/smp.c | 4 +---
> arch/powerpc/kernel/smp.c | 6 +-----
> arch/sh/include/asm/smp.h | 2 --
> arch/sh/kernel/smp.c | 4 +---
> arch/tile/kernel/smpboot.c | 4 +---
> arch/x86/include/asm/cpu.h | 2 --
> arch/x86/kernel/smpboot.c | 4 +---
> arch/x86/xen/smp.c | 1 +
> include/linux/smpboot.h | 1 +
> kernel/smpboot.c | 4 ++++
> 13 files changed, 13 insertions(+), 28 deletions(-)
>
[...]
> diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c
> index 97e7ce9..93cd4b0 100644
> --- a/arch/mips/cavium-octeon/smp.c
> +++ b/arch/mips/cavium-octeon/smp.c
> @@ -13,6 +13,7 @@
> #include<linux/kernel_stat.h>
> #include<linux/sched.h>
> #include<linux/module.h>
> +#include<linux/smpboot.h>
>
> #include<asm/mmu_context.h>
> #include<asm/time.h>
> @@ -252,9 +253,6 @@ static void octeon_cpus_done(void)
>
> #ifdef CONFIG_HOTPLUG_CPU
>
> -/* State of each CPU. */
> -DEFINE_PER_CPU(int, cpu_state);
> -
> extern void fixup_irqs(void);
>
> static DEFINE_SPINLOCK(smp_reserve_lock);
The Octeon bit:
Acked-by: David Daney <david.daney@cavium•com>
FWIW, the rest looks good too.
next prev parent reply other threads:[~2012-06-01 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120601090952.31979.24799.stgit@srivatsabhat.in.ibm.com>
2012-06-01 9:10 ` [PATCH 03/27] smpboot: Define and use cpu_state per-cpu variable in generic code Srivatsa S. Bhat
2012-06-01 16:59 ` David Daney [this message]
2012-06-01 9:14 ` [PATCH 18/27] powerpc, smpboot: Use generic SMP booting infrastructure Srivatsa S. Bhat
2012-06-02 6:14 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC8F4DB.2070906@gmail.com \
--to=ddaney.cavm@gmail$(echo .)com \
--cc=a.p.zijlstra@chello$(echo .)nl \
--cc=akpm@linux-foundation$(echo .)org \
--cc=cmetcalf@tilera$(echo .)com \
--cc=fenghua.yu@intel$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=jeremy@goop$(echo .)org \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=lethal@linux-sh$(echo .)org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=nikunj@linux$(echo .)vnet.ibm.com \
--cc=paulmck@linux$(echo .)vnet.ibm.com \
--cc=peterz@infradead$(echo .)org \
--cc=ralf@linux-mips$(echo .)org \
--cc=rjw@sisk$(echo .)pl \
--cc=rusty@rustcorp$(echo .)com.au \
--cc=srivatsa.bhat@linux$(echo .)vnet.ibm.com \
--cc=suresh.b.siddha@intel$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=vapier@gentoo$(echo .)org \
--cc=vatsa@linux$(echo .)vnet.ibm.com \
--cc=venki@google$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=x86@kernel$(echo .)org \
--cc=xen-devel@lists$(echo .)xensource.com \
--cc=yong.zhang0@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox