Subject: Re: [PATCH 2/2] powerpc/85xx: Create dts of each core in CAMP mode for P1021RDB-PC

From: Scott Wood <[email-masked]>
Date: Tue, 10 Jul 2012 10:57:51 -0500

On 07/10/2012 03:39 AM, Xu Jiucheng wrote:
> +		crypto@30000 {
> +                        status = "disabled";
> +                };

Whitespace.

> +
> +		mpic: pic@40000 {
> +			protected-sources = <
> +			16 		/* ecm, mem, L2, pci0, pci1 */
> +			43 42 59	/* i2c, serial0, spi */
> +			47 63 62 	/* gpio, tdm */
> +			20 21 22 23	/* dma */
> +			03 02 		/* mdio */
> +			29 30 34	/* enet0-queue-group0 */
> +			17 18 24	/* enet0-queue-group1 */
> +			35 36 40	/* enet1-queue-group0 */
> +			51 52 67	/* enet1-queue-group1 */
> +			28 72 45 58 	/* usb, sdhci, crypto */
> +			0xb0 0xb1 0xb2	/* message */
> +			0xb3 0xb4 0xb5
> +			0xb6 0xb7
> +			0xe0 0xe1 0xe2	/* msi */
> +			0xe3 0xe4 0xe5
> +			0xe6 0xe7		/* sdhci, crypto , pci */
> +			>;
> +			pic-no-reset;
> +		};

Besides what Timur said, do we really need protected-sources now that we
have pic-no-reset?

-Scott