Subject: Re: [linuxppc-release] [PATCH 4/4] Talitos: fix the issue of dma memory leak

From: Timur Tabi <[email-masked]>
Date: Tue, 10 Jul 2012 16:25:53 -0500

Qiang Liu wrote:
> An error will be happened when test with mass data:

Please don't use the phrase "fix the issue" in patch summaries.  It's
redundant.

This patch should be titled,

"drivers/crypto: fix memory leak in Talitos driver"

> diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
> index 81f8497..a7da48c 100644
> --- a/drivers/crypto/talitos.c
> +++ b/drivers/crypto/talitos.c
> @@ -264,7 +264,7 @@ static void flush_channel(struct device *dev, int ch, int error, int reset_ch)
>  			else
>  				status = error;
> 
> -		dma_unmap_single(dev, request->dma_desc,
> +		 dma_unmap_single(priv->dev, request->dma_desc,

You have an indentation problem here.

-- 
Timur Tabi
Linux kernel developer at Freescale