From: Scott Wood <scottwood@freescale•com>
To: Shengzhou Liu <Shengzhou.Liu@freescale•com>
Cc: bhelgaas@google•com, linux-pci@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH] PCI: use dev->irq instead of dev->pin to enable non MSI/INTx interrupt
Date: Tue, 17 Jul 2012 12:41:38 -0500 [thread overview]
Message-ID: <5005A3D2.5060504@freescale.com> (raw)
In-Reply-To: <1342492551-13766-1-git-send-email-Shengzhou.Liu@freescale.com>
On 07/16/2012 09:35 PM, Shengzhou Liu wrote:
> On some platforms, root port has neither MSI/MSI-X nor INTx interrupt
> generated in RC mode. In this case, we have to use other interrupt(i.e.
> system shared interrupt) for port service irq to have AER, Hot-plug, etc,
> services to work.
>
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale•com>
> ---
> drivers/pci/pcie/portdrv_core.c | 9 +++++++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c
> index 75915b3..a855254 100644
> --- a/drivers/pci/pcie/portdrv_core.c
> +++ b/drivers/pci/pcie/portdrv_core.c
> @@ -212,8 +212,13 @@ static int init_service_irqs(struct pci_dev *dev, int *irqs, int mask)
> if (!pcie_port_enable_msix(dev, irqs, mask))
> return 0;
>
> - /* We're not going to use MSI-X, so try MSI and fall back to INTx */
> - if (!pci_enable_msi(dev) || dev->pin)
> + /*
> + * We're not going to use MSI-X, so try MSI and fall back to INTx.
> + * If neither MSI/MSI-X nor INTx available, try other interrupt. (On
> + * some platforms, root port doesn't support generating MSI/MSI-X/INTx
> + * in RC mode)
> + */
> + if (!pci_enable_msi(dev) || dev->irq)
> irq = dev->irq;
What about the other usage of dev->pin a few lines up?
-Scott
next prev parent reply other threads:[~2012-07-17 17:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 2:35 [PATCH] PCI: use dev->irq instead of dev->pin to enable non MSI/INTx interrupt Shengzhou Liu
2012-07-17 17:41 ` Scott Wood [this message]
2012-07-18 6:36 ` Liu Shengzhou-B36685
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5005A3D2.5060504@freescale.com \
--to=scottwood@freescale$(echo .)com \
--cc=Shengzhou.Liu@freescale$(echo .)com \
--cc=bhelgaas@google$(echo .)com \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox