From: Scott Wood <scottwood@freescale•com>
To: Timur Tabi <timur@freescale•com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] powerpc/p5040ds: Add support for P5040DS board
Date: Tue, 24 Jul 2012 16:42:14 -0500 [thread overview]
Message-ID: <500F16B6.1080605@freescale.com> (raw)
In-Reply-To: <500F1545.1020705@freescale.com>
On 07/24/2012 04:36 PM, Timur Tabi wrote:
> Scott Wood wrote:
>
>>> It appears that this compatible string is used by U-Boot to find the nodes
>>> for fixups:
>>
>> SDK U-Boot, I assume you mean.
>
> No, upstream as well. It's pretty much the same code:
I don't see P5040 support in upstream U-Boot yet.
> #ifdef CONFIG_SYS_FSL_PCIE_COMPAT
> #define FSL_PCIE_COMPAT CONFIG_SYS_FSL_PCIE_COMPAT
> #else
> #define FSL_PCIE_COMPAT "fsl,mpc8548-pcie"
> #endif
>
> #define FT_FSL_PCIE1_SETUP __FT_FSL_PCIE_SETUP(blob, FSL_PCIE_COMPAT, 1)
> #define FT_FSL_PCIE2_SETUP __FT_FSL_PCIE_SETUP(blob, FSL_PCIE_COMPAT, 2)
> #define FT_FSL_PCIE3_SETUP __FT_FSL_PCIE_SETUP(blob, FSL_PCIE_COMPAT, 3)
> #define FT_FSL_PCIE4_SETUP __FT_FSL_PCIE_SETUP(blob, FSL_PCIE_COMPAT, 4)
>
> #define __FT_FSL_PCIE_SETUP(blob, compat, num) \
> ft_fsl_pci_setup(blob, compat, CONFIG_SYS_PCIE##num##_ADDR)
>
Yeah, the code's there, but not the wrong compatible string for P5040.
-Scott
next prev parent reply other threads:[~2012-07-24 21:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 16:42 [PATCH] powerpc/p5040ds: Add support for P5040DS board Timur Tabi
2012-07-24 17:56 ` Scott Wood
2012-07-24 18:09 ` Timur Tabi
2012-07-24 18:32 ` Scott Wood
2012-07-24 18:55 ` Timur Tabi
2012-07-24 20:42 ` Scott Wood
2012-07-25 2:55 ` Zang Roy-R61911
2012-07-24 19:40 ` Timur Tabi
2012-07-24 20:16 ` Timur Tabi
2012-07-24 20:45 ` Timur Tabi
2012-07-24 21:19 ` Timur Tabi
2012-07-24 21:31 ` Scott Wood
2012-07-24 21:36 ` Timur Tabi
2012-07-24 21:42 ` Scott Wood [this message]
2012-07-24 21:43 ` Timur Tabi
2012-07-24 21:45 ` Scott Wood
2012-07-24 21:47 ` Timur Tabi
2012-07-24 21:54 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500F16B6.1080605@freescale.com \
--to=scottwood@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=timur@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox