Subject: Re: [2/3][PATCH][upstream] TDM Framework

From: Tabi Timur-B04825 <[email-masked]>
Date: Wed, 25 Jul 2012 02:40:27 +0000

Michael Ellerman wrote:
> I agree these values are odd. But there's no rule that you can only use
> an enum if the values are monotonically increasing.
>
> It can still serve as helpful documentation, and reduce the number of
> places you pass a bare int around.

IMHO, an enum should only be used if

1) You are doing real type checking of the enum
2) You don't care what the actual values of each enum is

For this patch, neither is true.

--=20
Timur Tabi
Linux kernel developer at Freescale=