From: Wen Congyang <wency@cn•fujitsu.com>
To: gerald.schaefer@de•ibm.com
Cc: linux-s390@vger•kernel.org, linux-ia64@vger•kernel.org,
len.brown@intel•com, linux-acpi@vger•kernel.org,
linux-sh@vger•kernel.org,
Heiko Carstens <heiko.carstens@de•ibm.com>,
linux-kernel@vger•kernel.org, cmetcalf@tilera•com,
linux-mm@kvack•org,
Yasuaki ISIMATU <isimatu.yasuaki@jp•fujitsu.com>,
paulus@samba•org, minchan.kim@gmail•com,
kosaki.motohiro@jp•fujitsu.com, rientjes@google•com,
cl@linux•com, linuxppc-dev@lists•ozlabs.org,
akpm@linux-foundation•org, liuj97@gmail•com
Subject: Re: [RFC PATCH v5 12/19] memory-hotplug: introduce new function arch_remove_memory()
Date: Wed, 01 Aug 2012 09:42:22 +0800 [thread overview]
Message-ID: <5018897E.4040109@cn.fujitsu.com> (raw)
In-Reply-To: <20120731144000.33fd4a0a@thinkpad>
At 07/31/2012 08:40 PM, Gerald Schaefer Wrote:
> On Mon, 30 Jul 2012 18:35:37 +0800
> Wen Congyang <wency@cn•fujitsu.com> wrote:
>=20
>> At 07/30/2012 06:23 PM, Heiko Carstens Wrote:
>>> On Fri, Jul 27, 2012 at 06:32:15PM +0800, Wen Congyang wrote:
>>>> We don't call =5F=5Fadd=5Fpages() directly in the function add=5Fmemor=
y()
>>>> because some other architecture related things need to be done
>>>> before or after calling =5F=5Fadd=5Fpages(). So we should introduce
>>>> a new function arch=5Fremove=5Fmemory() to revert the things
>>>> done in arch=5Fadd=5Fmemory().
>>>>
>>>> Note: the function for s390 is not implemented(I don't know how to
>>>> implement it for s390).
>>>
>>> There is no hardware or firmware interface which could trigger a
>>> hot memory remove on s390. So there is nothing that needs to be
>>> implemented.
>>
>> Thanks for providing this information.
>>
>> According to this, arch=5Fremove=5Fmemory() for s390 can just return
>> -EBUSY.
>=20
> Yes, but there is a prototype mismatch for arch=5Fremove=5Fmemory() on s3=
90
> and also other architectures (u64 vs. unsigned long).
>=20
> arch/s390/mm/init.c:262: error: conflicting types for
> =E2=80=98arch=5Fremove=5Fmemory=E2=80=99 include/linux/memory=5Fhotplug.h=
:88: error: previous
> declaration of =E2=80=98arch=5Fremove=5Fmemory=E2=80=99 was here
>=20
> In memory=5Fhotplug.h you have:
> extern int arch=5Fremove=5Fmemory(unsigned long start, unsigned long size=
);
>=20
> On all archs other than x86 you have:
> int arch=5Fremove=5Fmemory(u64 start, u64 size)
Thanks for pointing it out. I will fix it.
Wen Congyang
>=20
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>=20
=
next prev parent reply other threads:[~2012-08-01 1:37 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 10:20 [RFC PATCH v5 00/19] memory-hotplug: hot-remove physical memory Wen Congyang
2012-07-27 10:22 ` [RFC PATCH 0/19] firmware_map : unify argument of firmware_map_add_early/hotplug Wen Congyang
2012-07-27 10:24 ` [PATCH 0.5/19] remove memory info from list before freeing it Wen Congyang
2012-07-27 10:25 ` [RFC PATCH v5 01/19] memory-hotplug: rename remove_memory() to offline_memory()/offline_pages() Wen Congyang
2012-07-27 10:26 ` [RFC PATCH v5 02/19] memory-hotplug: implement offline_memory() Wen Congyang
2012-07-27 10:27 ` [RFC PATCH v5 03/19] memory-hotplug: store the node id in acpi_memory_device Wen Congyang
2012-07-27 10:27 ` [RFC PATCH v5 04/19] memory-hotplug: offline and remove memory when removing the memory device Wen Congyang
2012-07-27 10:28 ` [RFC PATCH v5 05/19] memory-hotplug: check whether memory is present or not Wen Congyang
2012-07-27 20:17 ` Tony Luck
2012-07-30 1:57 ` Wen Congyang
2012-07-27 10:28 ` [RFC PATCH v5 06/19] memory-hotplug: export the function acpi_bus_remove() Wen Congyang
2012-07-27 10:29 ` [RFC PATCH v5 07/19] memory-hotplug: call acpi_bus_remove() to remove memory device Wen Congyang
2012-07-27 10:30 ` [RFC PATCH v5 08/19] memory-hotplug: remove /sys/firmware/memmap/X sysfs Wen Congyang
2012-07-27 10:30 ` [RFC PATCH v5 09/19] memory-hotplug: does not release memory region in PAGES_PER_SECTION chunks Wen Congyang
2012-07-27 10:31 ` [RFC PATCH v5 10/19] memory-hotplug: add memory_block_release Wen Congyang
2012-07-27 10:31 ` [RFC PATCH v5 11/19] memory-hotplug: remove_memory calls __remove_pages Wen Congyang
2012-07-27 10:32 ` [RFC PATCH v5 12/19] memory-hotplug: introduce new function arch_remove_memory() Wen Congyang
2012-07-30 10:23 ` Heiko Carstens
2012-07-30 10:35 ` Wen Congyang
2012-07-31 12:40 ` Gerald Schaefer
2012-08-01 1:42 ` Wen Congyang [this message]
2012-08-01 2:44 ` jencce zhou
2012-08-01 6:06 ` Wen Congyang
2012-07-27 10:32 ` [RFC PATCH v5 13/19] memory-hotplug: check page type in get_page_bootmem Wen Congyang
2012-07-27 10:33 ` [RFC PATCH v5 14/19] memory-hotplug: move register_page_bootmem_info_node and put_page_bootmem for sparse-vmemmap Wen Congyang
2012-07-27 10:34 ` [RFC PATCH v5 15/19] memory-hotplug: implement register_page_bootmem_info_section of sparse-vmemmap Wen Congyang
2012-07-27 10:34 ` [RFC PATCH v5 16/19] memory-hotplug: free memmap " Wen Congyang
2012-07-31 12:22 ` Gerald Schaefer
2012-08-01 6:09 ` Wen Congyang
2012-07-27 10:35 ` [RFC PATCH v5 17/19] memory_hotplug: clear zone when the memory is removed Wen Congyang
2012-07-27 10:35 ` [RFC PATCH v5 00/19] memory-hotplug: hot-remove physical memory Yasuaki Ishimatsu
2012-07-27 10:35 ` [RFC PATCH v5 18/19] memory-hotplug: add node_device_release Wen Congyang
2012-07-27 10:36 ` [RFC PATCH v5 19/19] memory-hotplug: remove sysfs file of node Wen Congyang
2012-07-27 10:45 ` Yasuaki Ishimatsu
2012-07-30 2:03 ` Wen Congyang
2012-07-30 3:47 ` Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5018897E.4040109@cn.fujitsu.com \
--to=wency@cn$(echo .)fujitsu.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=cl@linux$(echo .)com \
--cc=cmetcalf@tilera$(echo .)com \
--cc=gerald.schaefer@de$(echo .)ibm.com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=isimatu.yasuaki@jp$(echo .)fujitsu.com \
--cc=kosaki.motohiro@jp$(echo .)fujitsu.com \
--cc=len.brown@intel$(echo .)com \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=liuj97@gmail$(echo .)com \
--cc=minchan.kim@gmail$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=rientjes@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox