Subject: Re: [PATCH 2/4] fsl_pmc: Add API to enable device as wakeup event source

From: Tabi Timur-B04825 <[email-masked]>
Date: Tue, 14 Aug 2012 12:27:17 +0000

Zhao Chenhui wrote:
>>> > >+#ifdef CONFIG_FSL_PMC
>>> > >+extern int mpc85xx_pmc_set_wake(struct device *dev, bool enable);
>>> > >+extern void mpc85xx_pmc_set_lossless_ethernet(int enable);
>> >
>> >Don't use 'extern' for functions.
>> >
> Why? I think there is no difference.

It's unnecessary, and it makes the line longer.

--=20
Timur Tabi
Linux kernel developer at Freescale=