Subject: Re: [RFC v9 PATCH 03/21] memory-hotplug: store the node id in acpi_memory_device

From: Yasuaki Ishimatsu <[email-masked]>
Date: Mon, 1 Oct 2012 16:38:44 +0900

Hi Chen,

2012/09/28 12:21, Ni zhan Chen wrote:
> On 09/05/2012 05:25 PM, [email-masked] wrote:
>> From: Wen Congyang <[email-masked]>
>>
>> The memory device has only one node id. Store the node id when
>> enable the memory device, and we can reuse it when removing the
>> memory device.
>
> one question:
> if use numa emulation, memory device will associated to one node or ...?

Memory device has only one node, even if you use numa emulation.

Thanks,
Yasuaki Ishimatsu

>
>>
>> CC: David Rientjes <[email-masked]>
>> CC: Jiang Liu <[email-masked]>
>> CC: Len Brown <[email-masked]>
>> CC: Benjamin Herrenschmidt <[email-masked]>
>> CC: Paul Mackerras <[email-masked]>
>> CC: Christoph Lameter <[email-masked]>
>> Cc: Minchan Kim <[email-masked]>
>> CC: Andrew Morton <[email-masked]>
>> CC: KOSAKI Motohiro <[email-masked]>
>> CC: Yasuaki Ishimatsu <[email-masked]>
>> Signed-off-by: Wen Congyang <[email-masked]>
>> Reviewed-by: Yasuaki Ishimatsu <[email-masked]>
>> ---
>>   drivers/acpi/acpi_memhotplug.c |    4 ++++
>>   1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
>> index 2a7beac..7873832 100644
>> --- a/drivers/acpi/acpi_memhotplug.c
>> +++ b/drivers/acpi/acpi_memhotplug.c
>> @@ -83,6 +83,7 @@ struct acpi_memory_info {
>>   struct acpi_memory_device {
>>       struct acpi_device * device;
>>       unsigned int state;    /* State of the memory device */
>> +    int nid;
>>       struct list_head res_list;
>>   };
>> @@ -256,6 +257,9 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
>>           info->enabled = 1;
>>           num_enabled++;
>>       }
>> +
>> +    mem_device->nid = node;
>> +
>>       if (!num_enabled) {
>>           printk(KERN_ERR PREFIX "add_memory failed\n");
>>           mem_device->state = MEMORY_INVALID_STATE;
>