From: Robert Berger <robert.karl.berger@gmail•com>
To: Mai La <mla@apm•com>
Cc: wd@denx•de, linuxppc-dev@ozlabs•org
Subject: Re: ELDK 4.2/kilauea/3.5+ kernel broken
Date: Fri, 19 Oct 2012 09:35:52 +0300 [thread overview]
Message-ID: <5080F4C8.4000007@gmail.com> (raw)
In-Reply-To: <CAJ0-vuiccVbFk8=0TXO=Ak_a-0_yr55E2hs-GRVXLuKLNYjfCQ@mail.gmail.com>
Hi,
On 10/19/2012 06:16 AM, Mai La wrote:
> Hi,
>
> My patch was:
>
> @@ -150,12 +157,11 @@ static int ppc4xx_setup_pcieh_hw(struct
> platform_device *dev,
> if (!sdr_addr)
> return -1;
>
> - SDR0_WRITE(sdr_addr, (u64)res.start >> 32); /*HIGH addr */
> - SDR0_WRITE(sdr_addr + 1, res.start & 0xFFFFFFFF); /* Low addr */
> -
> + mtdcri(SDR0, *sdr_addr, upper_32_bits(res.start)); /*HIGH
> addr */
> + mtdcri(SDR0, *sdr_addr + 1, lower_32_bits(res.start)); /* Low
> addr */
>
> msi->msi_dev = of_find_node_by_name(NULL, "ppc4xx-msi");
> - if (msi->msi_dev)
> + if (!msi->msi_dev)
> return -ENODEV;
>
> msi->msi_regs = of_iomap(msi->msi_dev, 0);
>
>
> 1. The first few lines: change from SDR0_WRITE to mtdcri since the old
> one cause crash. I use ELDK 4.2.
The old one does not cause a crash for me. As I said on a kilauea board
with ELDK 4.2 a 3.6 kernel, default config and everything reverted to
the good old file I can boot happily with a rootfs from nfs.
If I use the file as it is in 3.6 I don't see the kernel booting. but it
crashes.
>
> 2. The second one should mean that: if not find any node then return
> error. So it should be "!msi->msi_dev"
In the 3.6 kernel it's with ! the old file (which works for me) is
without the !
... very strange ...
>
> Regards,
> Mai La.
>
>
Regards,
Robert
next prev parent reply other threads:[~2012-10-19 6:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <507EF5AD.5070203__24977.4320669987$1350497770$gmane$org@gmail.com>
2012-10-18 16:27 ` ELDK 4.2/kilauea/3.5+ kernel broken Robert Berger
2012-10-18 16:33 ` Robert Berger
[not found] ` <50802F4C.3000309__36526.1883860969$1350578085$gmane$org@gmail.com>
2012-10-18 17:45 ` Robert Berger
2012-10-18 19:03 ` Benjamin Herrenschmidt
2012-10-18 20:05 ` Robert Berger
2012-10-19 3:16 ` Mai La
2012-10-19 6:35 ` Robert Berger [this message]
[not found] ` <1350587006.2476.12.camel__24873.815305955$1350587085$gmane$org@pasglop>
2012-10-21 15:35 ` Robert Berger
2012-10-21 20:01 ` Benjamin Herrenschmidt
[not found] ` <1350849666.2476.138.camel__11705.9888471433$1350849778$gmane$org@pasglop>
2012-10-24 5:45 ` Robert Berger
2013-01-04 4:08 ` Benjamin Herrenschmidt
2012-10-21 15:39 ` Robert Berger
2012-10-17 18:15 Robert Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5080F4C8.4000007@gmail.com \
--to=robert.karl.berger@gmail$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mla@apm$(echo .)com \
--cc=wd@denx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox