From: Chen Gang <gang.chen@asianux•com>
To: Jiri Slaby <jslaby@suse•cz>, benh@kernel•crashing.org
Cc: Greg KH <gregkh@linuxfoundation•org>,
tklauser@distanz•ch, wfp5p@virginia•edu,
linuxppc-dev@lists•ozlabs.org, alan@linux•intel.com
Subject: Re: [PATCH] drivers/tty/hvc: using strlcpy instead of strncpy
Date: Thu, 07 Mar 2013 12:34:52 +0800 [thread overview]
Message-ID: <513818EC.9050504@asianux.com> (raw)
In-Reply-To: <51381352.9090803@asianux.com>
oh, this patch has integrated into next-20130307 tree.
(commit 9276dfd27897a0b29d8b5814f39a1f82f56b6b6b)
it seems we need a regression for this commit, then I send patch v2
is it correct ?
:-)
于 2013年03月07日 12:10, Chen Gang 写道:
> 于 2013年03月05日 17:36, Jiri Slaby 写道:
>> On 03/05/2013 02:58 AM, Chen Gang wrote:
>>>> 于 2013年02月28日 21:47, Jiri Slaby 写道:
>>>>>>>>>> when strlen(&pi->location_code[0]) == HVCS_CLC_LENGTH + 2
>>>>>> It cannot, pi->location_code is defined as char[HVCS_CLC_LENGTH + 1].
>>>>>>
>>>>
>>>> really, it is, I did not notice it.
>>>>
>>>> but I still prefer to modify it, but the patch should be changed
>>>> such as:
>>>> subject: beautify code: deleting useless judging code.
>>>> comments: src buf len and dest buf len are the same, strcpy is better.
>>>> contents: using strcpy instead of strncpy, and delete judging code.
>>>>
>>>> is it ok ?
>> Yeah.
>>
>
> I will send patch v2.
>
>
>>>> BTW:
>>>> sorry for my reply is too late, and did not notify it, originally before.
>>>> I have to do some urgent things, during these days.
>>>> my father had a serious heart disease, and is in hospital.
>> No problem, these drivers are not so critical. Neither these code paths
>> in them. Take care of your relatives first.
>
> thanks.
>
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-03-07 4:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 3:43 [PATCH] drivers/tty/hvc: using strlcpy instead of strncpy Chen Gang
2013-02-28 10:41 ` Jiri Slaby
2013-02-28 11:13 ` Chen Gang
2013-02-28 11:15 ` Chen Gang
2013-02-28 13:47 ` Jiri Slaby
2013-03-05 1:58 ` Chen Gang
2013-03-05 9:36 ` Jiri Slaby
2013-03-07 4:10 ` Chen Gang
2013-03-07 4:34 ` Chen Gang [this message]
2013-03-07 6:05 ` Benjamin Herrenschmidt
2013-03-07 7:10 ` Chen Gang
2013-03-08 3:38 ` [PATCH] drivers/tty/hvc: fixup original commit: 9276dfd27897a0b29d8b5814f39a1f82f56b6b6b Chen Gang
2013-03-08 3:46 ` Benjamin Herrenschmidt
2013-03-08 4:23 ` Chen Gang
2013-03-08 4:33 ` Benjamin Herrenschmidt
2013-03-08 4:40 ` Chen Gang
2013-03-08 5:08 ` Benjamin Herrenschmidt
2013-03-08 6:12 ` Chen Gang
2013-03-08 11:11 ` David Laight
2013-03-10 1:18 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513818EC.9050504@asianux.com \
--to=gang.chen@asianux$(echo .)com \
--cc=alan@linux$(echo .)intel.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=jslaby@suse$(echo .)cz \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=tklauser@distanz$(echo .)ch \
--cc=wfp5p@virginia$(echo .)edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox