Subject: Re: [PATCH] arch/powerpc/kernel: using %12.12s instead of %12s for avoiding memory overflow.

From: Chen Gang <[email-masked]>
Date: Mon, 25 Mar 2013 12:30:24 +0800

Hello Maintainers:

  could you help check this patch whether is ok ?

  thanks.

On 2013年02月17日 12:00, Chen Gang wrote:
> Hello relative members:
> 
>   please give a glance to this patch, when you have time.
> 
>   thanks.
> 
>   :-)
> 
> gchen.
> 
> 
> 于 2013年01月24日 12:14, Chen Gang 写道:
>>
>>   for tmp_part->header.name:
>>     it is "Terminating null required only for names < 12 chars".
>>     so need to limit the %.12s for it in printk
>>
>>   additional info:
>>
>>     %12s  limit the width, not for the original string output length
>>           if name length is more than 12, it still can be fully displayed.
>>           if name length is less than 12, the ' ' will be filled before name.
>>
>>     %.12s truly limit the original string output length (precision)
>>
>>
>> Signed-off-by: Chen Gang <[email-masked]>
>> ---
>>  arch/powerpc/kernel/nvram_64.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/kernel/nvram_64.c
>> index bec1e93..57bf6d2 100644
>> --- a/arch/powerpc/kernel/nvram_64.c
>> +++ b/arch/powerpc/kernel/nvram_64.c
>> @@ -202,7 +202,7 @@ static void __init nvram_print_partitions(char * label)
>>  	printk(KERN_WARNING "--------%s---------\n", label);
>>  	printk(KERN_WARNING "indx\t\tsig\tchks\tlen\tname\n");
>>  	list_for_each_entry(tmp_part, &nvram_partitions, partition) {
>> -		printk(KERN_WARNING "%4d    \t%02x\t%02x\t%d\t%12s\n",
>> +		printk(KERN_WARNING "%4d    \t%02x\t%02x\t%d\t%12.12s\n",
>>  		       tmp_part->index, tmp_part->header.signature,
>>  		       tmp_part->header.checksum, tmp_part->header.length,
>>  		       tmp_part->header.name);
>>
> 
> 

-- 
Chen Gang

Asianux Corporation