Subject: [BUG?] possible bug in user_enable_block_step()

From: Chris Friesen <[email-masked]>
Date: Thu, 11 Apr 2013 16:38:30 -0600

Hi,

I'm looking at user_enable_block_step() in current kernels and it has 
the following:

#ifdef CONFIG_PPC_ADV_DEBUG_REGS
		task->thread.dbcr0 &= ~DBCR0_IC;
		task->thread.dbcr0 = DBCR0_IDM | DBCR0_BT;
		regs->msr |= MSR_DE;

Should it be as follows?

		task->thread.dbcr0 |= DBCR0_IDM | DBCR0_BT;

If not, then what's the point of clearing the DBCR0_IC bit in the 
previous line?

Chris

-- 

Chris Friesen
Software Designer

500 Palladium Drive, Suite 2100
Ottawa, Ontario K2N 1C2, Canada
www.genband.com
office:+1.343.883.2717
[email-masked]