From: Lucas Kannebley Tavares <lucaskt@linux•vnet.ibm.com>
To: Michael Ellerman <michael@ellerman•id.au>
Cc: David Airlie <airlied@linux•ie>,
Brian King <brking@linux•vnet.ibm.com>,
dri-devel@lists•freedesktop.org,
Kleber Sacilotto de Souza <klebers@linux•vnet.ibm.com>,
Alex Deucher <alexander.deucher@amd•com>,
Jerome Glisse <jglisse@redhat•com>,
Thadeu Lima de Souza Cascardo <cascardo@linux•vnet.ibm.com>,
Bjorn Helgaas <bhelgaas@google•com>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCHv3 1/2] ppc64: perform proper max_bus_speed detection
Date: Wed, 17 Apr 2013 09:38:40 -0300 [thread overview]
Message-ID: <516E97D0.5090708@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130415050001.GA21147@concordia>
On 04/15/2013 02:00 AM, Michael Ellerman wrote:
> On Thu, Apr 11, 2013 at 10:13:13AM -0300, Lucas Kannebley Tavares wrote:
>> On pseries machines the detection for max_bus_speed should be done
>> through an OpenFirmware property. This patch adds a function to perform this
>> detection and a hook to perform dynamic adding of the function only for
>> pseries.
>
> The crucial detail you didn't mention is that pcibios_root_bridge_prepare()
> already exists as a weak function in the PCI code and is called from
> pci_create_root_bus().
Adding this comment.
>
>> diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c
>> index 8bcc9ca..15796b5 100644
>> --- a/arch/powerpc/platforms/pseries/setup.c
>> +++ b/arch/powerpc/platforms/pseries/setup.c
>> @@ -430,6 +430,8 @@ static void pSeries_machine_kexec(struct kimage *image)
>> }
>> #endif
>>
>> +int pseries_root_bridge_prepare(struct pci_host_bridge *bridge);
>> +
>
> Don't do that, put it in a header where it belongs.
>
And done as well.
> cheers
>
--
Lucas Kannebley Tavares
Software Engineer
IBM Linux Technology Center
next prev parent reply other threads:[~2013-04-17 12:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 13:13 [PATCHv3 0/2] Speed Cap fixes for ppc64 Lucas Kannebley Tavares
2013-04-11 13:13 ` [PATCHv3 1/2] ppc64: perform proper max_bus_speed detection Lucas Kannebley Tavares
2013-04-15 5:00 ` Michael Ellerman
2013-04-17 12:38 ` Lucas Kannebley Tavares [this message]
2013-04-15 11:42 ` Michael Ellerman
2013-04-17 12:40 ` Lucas Kannebley Tavares
2013-04-11 13:13 ` [PATCHv3 2/2] radeon: use max_bus_speed to activate gen2 speeds Lucas Kannebley Tavares
2013-04-12 16:38 ` Bjorn Helgaas
2013-04-16 3:17 ` Dave Airlie
2013-04-17 12:38 ` Lucas Kannebley Tavares
2013-04-17 20:04 ` Alex Deucher
2013-04-17 20:11 ` Bjorn Helgaas
2013-04-17 20:17 ` Alex Deucher
2013-04-17 20:30 ` Bjorn Helgaas
2013-04-12 13:52 ` [PATCHv3 0/2] Speed Cap fixes for ppc64 Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516E97D0.5090708@linux.vnet.ibm.com \
--to=lucaskt@linux$(echo .)vnet.ibm.com \
--cc=airlied@linux$(echo .)ie \
--cc=alexander.deucher@amd$(echo .)com \
--cc=bhelgaas@google$(echo .)com \
--cc=brking@linux$(echo .)vnet.ibm.com \
--cc=cascardo@linux$(echo .)vnet.ibm.com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=jglisse@redhat$(echo .)com \
--cc=klebers@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=michael@ellerman$(echo .)id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox