From: Rob Herring <robherring2@gmail•com>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: Roland Dreier <roland@kernel•org>, Arnd Bergmann <arnd@arndb•de>,
linux-rdma@vger•kernel.org, netdev@vger•kernel.org,
"devicetree-discuss@lists•ozlabs.org"
<devicetree-discuss@lists•ozlabs.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
Christoph Raisch <raisch@de•ibm.com>,
Hoang-Nam Nguyen <hnguyen@de•ibm.com>,
Thadeu Lima de Souza Cascardo <cascardo@linux•vnet.ibm.com>,
Grant Likely <grant.likely@linaro•org>,
Paul Mackerras <paulus@samba•org>,
Sean Hefty <sean.hefty@intel•com>,
linuxppc-dev@lists•ozlabs.org,
Hal Rosenstock <hal.rosenstock@gmail•com>
Subject: Re: [PATCH 1/5] ibmebus: convert of_platform_driver to platform_driver
Date: Thu, 25 Apr 2013 14:14:56 -0500 [thread overview]
Message-ID: <517980B0.3000401@gmail.com> (raw)
In-Reply-To: <1366911329.2869.31.camel@pasglop>
On 04/25/2013 12:35 PM, Benjamin Herrenschmidt wrote:
> On Thu, 2013-04-25 at 10:23 -0500, Rob Herring wrote:
>> Ben, Can I have your Ack for this? The change is straightforward and
>> neither of the 2 drivers used the id parameter that is removed.
>
> Didn't you get my mail about a compile failure caused by this patch ?
No, and I can't find any evidence of a mail in my inbox or in the list
archives.
>
> A quick build test leads to:
>
> /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c: In function 'ibmebus_bus_device_probe':
> /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c:344:2: error: implicit declaration of function 'to_platform_driver' [-Werror=implicit-function-declaration]
> /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c:344:6: error: assignment makes pointer from integer without a cast [-Werror]
> /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c: In function 'ibmebus_bus_device_remove':
> /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c:363:32: error: initialization makes pointer from integer without a cast [-Werror]
> /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c: In function 'ibmebus_bus_device_shutdown':
> /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c:373:32: error: initialization makes pointer from integer without a cast [-Werror]
> /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c: In function 'ibmebus_bus_legacy_suspend':
> /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c:420:32: error: initialization makes pointer from integer without a cast [-Werror]
> /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c: In function 'ibmebus_bus_legacy_resume':
> /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c:431:32: error: initialization makes pointer from integer without a cast [-Werror]
> cc1: all warnings being treated as errors
> make[2]: *** [arch/powerpc/kernel/ibmebus.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
>
> Haven't had a chance to look too closely today -EJETLAG :-)
You need patch 2 of this series to fix this:
driver core: move to_platform_driver to platform_device.h
which as Arnd pointed out needs to come first. I've fixed that in my
tree, but I don't think it warrants another post.
Rob
next prev parent reply other threads:[~2013-04-25 19:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 2:13 [PATCH 0/5] of_platform_driver and OF_DEVICE removal Rob Herring
2013-04-22 2:13 ` [PATCH 1/5] ibmebus: convert of_platform_driver to platform_driver Rob Herring
2013-04-25 15:23 ` Rob Herring
2013-04-25 17:35 ` Benjamin Herrenschmidt
2013-04-25 19:14 ` Rob Herring [this message]
2013-04-25 20:12 ` Benjamin Herrenschmidt
2013-04-25 20:45 ` Rob Herring
2013-05-22 12:26 ` Rob Herring
2013-05-22 12:32 ` Benjamin Herrenschmidt
2013-06-12 5:29 ` Benjamin Herrenschmidt
2013-06-12 11:40 ` Grant Likely
2013-04-22 7:03 ` [PATCH 0/5] of_platform_driver and OF_DEVICE removal Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517980B0.3000401@gmail.com \
--to=robherring2@gmail$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=cascardo@linux$(echo .)vnet.ibm.com \
--cc=devicetree-discuss@lists$(echo .)ozlabs.org \
--cc=grant.likely@linaro$(echo .)org \
--cc=hal.rosenstock@gmail$(echo .)com \
--cc=hnguyen@de$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paulus@samba$(echo .)org \
--cc=raisch@de$(echo .)ibm.com \
--cc=roland@kernel$(echo .)org \
--cc=sean.hefty@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox