From: Chen Gang <gang.chen@asianux•com>
To: Arnd Bergmann <arnd@arndb•de>
Cc: "Catalin Marinas" <Catalin.Marinas@arm•com>,
"Linux-sh list" <linux-sh@vger•kernel.org>,
"Heiko Carstens" <heiko.carstens@de•ibm.com>,
"paulus@samba•org" <paulus@samba•org>,
"H. Peter Anvin" <hpa@zytor•com>,
"Michel Lespinasse" <walken@google•com>,
"Hans-Christian Egtvedt" <egtvedt@samfundet•no>,
Linux-Arch <linux-arch@vger•kernel.org>,
linux-s390@vger•kernel.org,
"Russell King - ARM Linux" <linux@arm•linux.org.uk>,
"Yoshinori Sato" <ysato@users•sourceforge.jp>,
"Richard Weinberger" <richard@nod•at>,
"Helge Deller" <deller@gmx•de>,
"the arch/x86 maintainers" <x86@kernel•org>,
"James E.J. Bottomley" <jejb@parisc-linux•org>,
"mingo@redhat•com" <mingo@redhat•com>,
"Geert Uytterhoeven" <geert@linux-m68k•org>,
"Frederic Weisbecker" <fweisbec@gmail•com>,
"Paul McKenney" <paulmck@linux•vnet.ibm.com>,
"Håvard Skinnemoen" <hskinnemoen@gmail•com>,
"Serge Hallyn" <serge.hallyn@canonical•com>,
"Mike Frysinger" <vapier@gentoo•org>,
uml-devel <user-mode-linux-devel@lists•sourceforge.net>,
"Will Deacon" <will.deacon@arm•com>,
"Jeff Dike" <jdike@addtoit•com>,
"Akinobu Mita" <akinobu.mita@gmail•com>,
uml-user <user-mode-linux-user@lists•sourceforge.net>,
"uclinux-dist-devel@blackfin•uclinux.org"
<uclinux-dist-devel@blackfin•uclinux.org>,
"Thomas Gleixner" <tglx@linutronix•de>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"Parisc List" <linux-parisc@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"Richard Kuo" <rkuo@codeaurora•org>,
"Paul Mundt" <lethal@linux-sh•org>,
"Eric W. Biederman" <ebiederm@xmission•com>,
linux-hexagon@vger•kernel.org,
"Martin Schwidefsky" <schwidefsky@de•ibm.com>,
linux390@de•ibm.com, "Andrew Morton" <akpm@linux-foundation•org>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
"David Miller" <davem@davemloft•net>
Subject: Re: [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it.
Date: Thu, 23 May 2013 19:19:30 +0800 [thread overview]
Message-ID: <519DFB42.7010509@asianux.com> (raw)
In-Reply-To: <201305231259.43750.arnd@arndb.de>
On 05/23/2013 06:59 PM, Arnd Bergmann wrote:
> You don't just want to avoid the code for printing the bug message and
> the invalid instruction, we also want the compiler to not emit the
> function call or check the enum for unexpected values. The meaning of
> BUG() is really that person writing that statement was sure it cannot
> happen unless there is a bug in the kernel, which has likely already
> corrupted data. Printing a diagnostic at this point is nice if someone
> is there to look at it, but letting the kernel do further actions that
> may be undefined is not going to make things worse.
So I think neither unreachable() nor panic() are suitable for this
condition.
I guess 'CONFIG_BUG' is not belong to common features, now (and in the
future), so it is not suitable still exist in "asm-generic/bug.h", need
remove it firstly.
And then let the specific architectures to implement their own BUG(), if
they want some special features.
SO most of arches can skip this issue.
Thanks.
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-05-23 11:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 7:57 [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it Chen Gang
2013-05-23 8:40 ` Geert Uytterhoeven
2013-05-23 8:54 ` Arnd Bergmann
2013-05-23 9:05 ` Russell King - ARM Linux
2013-05-23 9:12 ` Geert Uytterhoeven
2013-05-23 9:39 ` Arnd Bergmann
2013-05-23 10:04 ` Russell King - ARM Linux
2013-05-23 10:41 ` Chen Gang
2013-05-23 10:59 ` Arnd Bergmann
2013-05-23 11:19 ` Chen Gang [this message]
2013-05-23 11:24 ` Russell King - ARM Linux
2013-05-23 12:09 ` Arnd Bergmann
2013-05-23 12:50 ` Russell King - ARM Linux
2013-05-23 14:10 ` Geert Uytterhoeven
2013-05-24 2:13 ` Chen Gang
2013-05-24 4:17 ` Chen Gang
2013-05-26 4:43 ` [PATCH v2] arch: configuration issue, random return value when disable 'CONFIG_BUG' Chen Gang
2013-05-28 8:19 ` [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it Ingo Molnar
2013-05-28 10:25 ` Chen Gang
2013-05-28 14:49 ` Arnd Bergmann
2013-05-28 14:55 ` H. Peter Anvin
2013-05-28 15:43 ` Arnd Bergmann
2013-05-28 16:06 ` H. Peter Anvin
2013-05-28 17:20 ` Arnd Bergmann
2013-05-23 10:09 ` Eric W. Biederman
2013-05-23 10:29 ` Russell King - ARM Linux
2013-05-23 10:05 ` Chen Gang
2013-05-24 5:59 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519DFB42.7010509@asianux.com \
--to=gang.chen@asianux$(echo .)com \
--cc=Catalin.Marinas@arm$(echo .)com \
--cc=akinobu.mita@gmail$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=ebiederm@xmission$(echo .)com \
--cc=egtvedt@samfundet$(echo .)no \
--cc=fweisbec@gmail$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=hskinnemoen@gmail$(echo .)com \
--cc=jdike@addtoit$(echo .)com \
--cc=jejb@parisc-linux$(echo .)org \
--cc=lethal@linux-sh$(echo .)org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-hexagon@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux390@de$(echo .)ibm.com \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@redhat$(echo .)com \
--cc=paulmck@linux$(echo .)vnet.ibm.com \
--cc=paulus@samba$(echo .)org \
--cc=richard@nod$(echo .)at \
--cc=rkuo@codeaurora$(echo .)org \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=serge.hallyn@canonical$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=uclinux-dist-devel@blackfin$(echo .)uclinux.org \
--cc=user-mode-linux-devel@lists$(echo .)sourceforge.net \
--cc=user-mode-linux-user@lists$(echo .)sourceforge.net \
--cc=vapier@gentoo$(echo .)org \
--cc=walken@google$(echo .)com \
--cc=will.deacon@arm$(echo .)com \
--cc=x86@kernel$(echo .)org \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox