From: Santosh Shilimkar <santosh.shilimkar@ti•com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix•de>,
<robherring2@gmail•com>
Cc: Nicolas Pitre <nicolas.pitre@linaro•org>,
linux-mips@linux-mips•org,
Catalin Marinas <catalin.marinas@arm•com>,
Aurelien Jacquiot <a-jacquiot@ti•com>,
Will Deacon <will.deacon@arm•com>,
Max Filippov <jcmvbkbc@gmail•com>,
Paul Mackerras <paulus@samba•org>,
Jonas Bonn <jonas@southpole•se>,
Russell King <linux@arm•linux.org.uk>,
linux-c6x-dev@linux-c6x•org, x86@kernel•org, arm@kernel•org,
Mark Salter <msalter@redhat•com>,
Grant Likely <grant.likely@linaro•org>,
linux-xtensa@linux-xtensa•org,
James Hogan <james.hogan@imgtec•com>,
devicetree-discuss@lists•ozlabs.org,
Rob Herring <rob.herring@calxeda•com>,
linux-arm-kernel@lists•infradead.org,
Chris Zankel <chris@zankel•net>, Michal Simek <monstr@monstr•eu>,
Vineet Gupta <vgupta@synopsys•com>,
linux-kernel@vger•kernel.org, Ralf Baechle <ralf@linux-mips•org>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH] of: Specify initrd location using 64-bit
Date: Fri, 21 Jun 2013 13:20:26 -0400 [thread overview]
Message-ID: <51C48B5A.2040404@ti.com> (raw)
In-Reply-To: <51C4171C.9050908@linutronix.de>
On Friday 21 June 2013 05:04 AM, Sebastian Andrzej Siewior wrote:
> On 06/21/2013 02:52 AM, Santosh Shilimkar wrote:
>> diff --git a/arch/microblaze/kernel/prom.c b/arch/microblaze/kernel/prom.c
>> index 0a2c68f..62e2e8f 100644
>> --- a/arch/microblaze/kernel/prom.c
>> +++ b/arch/microblaze/kernel/prom.c
>> @@ -136,8 +136,7 @@ void __init early_init_devtree(void *params)
>> }
>>
>> #ifdef CONFIG_BLK_DEV_INITRD
>> -void __init early_init_dt_setup_initrd_arch(unsigned long start,
>> - unsigned long end)
>> +void __init early_init_dt_setup_initrd_arch(u64 start, u64 end)
>> {
>> initrd_start = (unsigned long)__va(start);
>> initrd_end = (unsigned long)__va(end);
>
> I think it would better to go here for phys_addr_t instead of u64. This
> would force you in of_flat_dt_match() to check if the value passed from
> DT specifies a memory address outside of 32bit address space and the
> kernel can't deal with this because its phys_addr_t is 32bit only due
> to a Kconfig switch.
>
> For x86, the initrd has to remain in the 32bit address space so passing
> the initrd in the upper range would violate the ABI. Not sure if this
> is true for other archs as well (ARM obviously not).
>
That pretty much means phys_addr_t. It will work for me as well but
in last thread from consistency with memory and reserved node, Rob
insisted to keep it as u64. So before I re-spin another version,
would like to here what Rob has to say considering the x86 requirement.
Rob,
Are you ok with phys_addr_t since your concern was about rest
of the memory specific bits of the device-tree code use u64 ?
Regards,
Santosh
next prev parent reply other threads:[~2013-06-21 17:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 0:52 [PATCH] of: Specify initrd location using 64-bit Santosh Shilimkar
2013-06-21 4:39 ` Vineet Gupta
2013-06-21 8:23 ` James Hogan
2013-06-21 17:12 ` Santosh Shilimkar
2013-06-21 9:04 ` Sebastian Andrzej Siewior
2013-06-21 17:20 ` Santosh Shilimkar [this message]
2013-06-27 20:54 ` Rob Herring
2013-06-28 7:54 ` Sebastian Andrzej Siewior
2013-06-28 9:59 ` Grant Likely
2013-06-28 13:49 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-28 23:43 ` Santosh Shilimkar
2013-06-29 8:34 ` Geert Uytterhoeven
2013-07-01 7:48 ` Sebastian Andrzej Siewior
2013-07-01 7:59 ` Geert Uytterhoeven
2013-07-01 8:09 ` Sebastian Andrzej Siewior
2013-07-01 13:58 ` Santosh Shilimkar
-- strict thread matches above, loose matches on Subject: below --
2012-09-12 16:05 [PATCH] of: specify " Cyril Chemparathy
2012-09-12 16:16 ` Geert Uytterhoeven
2012-09-12 18:02 ` Cyril Chemparathy
2012-09-12 19:58 ` Sebastian Andrzej Siewior
2012-09-12 22:08 ` Rob Herring
2012-09-13 6:47 ` Sebastian Andrzej Siewior
2012-09-13 21:02 ` Rob Herring
2012-09-12 20:23 ` Rob Herring
2012-09-12 20:31 ` Nicolas Pitre
2012-09-12 20:56 ` Rob Herring
2012-09-12 23:45 ` Cyril Chemparathy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C48B5A.2040404@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=a-jacquiot@ti$(echo .)com \
--cc=arm@kernel$(echo .)org \
--cc=bigeasy@linutronix$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chris@zankel$(echo .)net \
--cc=devicetree-discuss@lists$(echo .)ozlabs.org \
--cc=grant.likely@linaro$(echo .)org \
--cc=james.hogan@imgtec$(echo .)com \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=jonas@southpole$(echo .)se \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-c6x-dev@linux-c6x$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-xtensa@linux-xtensa$(echo .)org \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=monstr@monstr$(echo .)eu \
--cc=msalter@redhat$(echo .)com \
--cc=nicolas.pitre@linaro$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=ralf@linux-mips$(echo .)org \
--cc=rob.herring@calxeda$(echo .)com \
--cc=robherring2@gmail$(echo .)com \
--cc=vgupta@synopsys$(echo .)com \
--cc=will.deacon@arm$(echo .)com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox