From: Tudor Laurentiu <Laurentiu.Tudor@freescale•com>
To: Scott Wood <scottwood@freescale•com>
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH][v2] powerpc/85xx: Move ePAPR paravirt initialization earlier
Date: Wed, 3 Jul 2013 18:13:14 +0300 [thread overview]
Message-ID: <51D43F8A.7060008@freescale.com> (raw)
In-Reply-To: <1372863166.8183.129@snotra>
On 07/03/2013 05:52 PM, Scott Wood wrote:
> On 07/03/2013 07:29:43 AM, Tudor Laurentiu wrote:
>> On 07/02/2013 08:55 PM, Scott Wood wrote:
>>> On 07/02/2013 07:46:29 AM, Laurentiu Tudor wrote:
>>>> - insts = of_get_property(hyper_node, "hcall-instructions", &len);
>>>> - if (!insts)
>>>> - return -ENODEV;
>>>> +#if !defined(CONFIG_64BIT) || defined(CONFIG_PPC_BOOK3E_64)
>>>> + if (of_get_flat_dt_prop(node, "has-idle", NULL))
>>>> + ppc_md.power_save = epapr_ev_idle;
>>>> +#endif
>>>
>>> Why are you doing this before processing hcall-instructions?
>>>
>>
>> Nothing of importance. The code seemed more clear to me.
>
> It seems wrong to expose epapr_ev_idle to ppc_md before the hcall has
> been patched in, even if you don't expect to actually go idle at this
> point.
>
Ah, now I understand your concerns. I've submitted a [v3] restoring the
original ordering.
---
Best Regards, Laurentiu
prev parent reply other threads:[~2013-07-03 15:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 12:46 [PATCH][v2] powerpc/85xx: Move ePAPR paravirt initialization earlier Laurentiu Tudor
2013-07-02 17:55 ` Scott Wood
2013-07-03 12:29 ` Tudor Laurentiu
2013-07-03 14:52 ` Scott Wood
2013-07-03 15:13 ` Tudor Laurentiu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D43F8A.7060008@freescale.com \
--to=laurentiu.tudor@freescale$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox