From: Timur Tabi <timur@tabi•org>
To: Alexander Popov <a13xp0p0v88@gmail•com>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
Anatolij Gustschin <agust@denx•de>,
Grant Likely <grant.likely@linaro•org>,
Rob Herring <rob.herring@calxeda•com>,
Chris Ball <cjb@laptop•org>,
Sascha Hauer <s.hauer@pengutronix•de>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
Subject: Re: [V2 2/2] powerpc/512x: add LocalPlus Bus FIFO device driver
Date: Wed, 10 Jul 2013 09:01:15 -0500 [thread overview]
Message-ID: <51DD692B.70909@tabi.org> (raw)
In-Reply-To: <20130710134624.GC2615@book.gsilab.sittig.org>
Gerhard Sittig wrote:
>> >+ * Author is Alexander Popov<a13xp0p0v88@gmail•com>.
> nit pick: is 1337 speak usual and appropriate here?
Um, that's his actual email address.
> shouldn't headers get sorted alphabetically?
Is that a new policy? I've never heard that requirement.
>> +MODULE_AUTHOR("Alexander Popov <a13xp0p0v88@gmail•com>");
>> +MODULE_DESCRIPTION("MPC512x LocalPlus FIFO device driver");
>> +MODULE_LICENSE("GPL");
>
> aren't these usually at the end of the source for quick lookup?
Yes, and it should be "GPL v2" also.
--
Timur Tabi
next prev parent reply other threads:[~2013-07-10 14:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 10:21 [V2 2/2] powerpc/512x: add LocalPlus Bus FIFO device driver Alexander Popov
2013-07-10 13:46 ` Gerhard Sittig
2013-07-10 13:57 ` Rob Herring
2013-07-10 14:01 ` Timur Tabi [this message]
2013-07-12 10:42 ` Alexander Popov
2013-07-17 9:03 ` Gerhard Sittig
2013-07-26 5:31 ` Alexander Popov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DD692B.70909@tabi.org \
--to=timur@tabi$(echo .)org \
--cc=a13xp0p0v88@gmail$(echo .)com \
--cc=agust@denx$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=cjb@laptop$(echo .)org \
--cc=grant.likely@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=rob.herring@calxeda$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox