Subject: Re: [V2 2/2] powerpc/512x: add LocalPlus Bus FIFO device driver

From: Timur Tabi <[email-masked]>
Date: Wed, 10 Jul 2013 09:01:15 -0500

Gerhard Sittig wrote:
>> >+ * Author is Alexander Popov<[email-masked]>.

> nit pick:  is 1337 speak usual and appropriate here?

Um, that's his actual email address.

> shouldn't headers get sorted alphabetically?

Is that a new policy?  I've never heard that requirement.

>> +MODULE_AUTHOR("Alexander Popov <[email-masked]>");
>> +MODULE_DESCRIPTION("MPC512x LocalPlus FIFO device driver");
>> +MODULE_LICENSE("GPL");
>
> aren't these usually at the end of the source for quick lookup?

Yes, and it should be "GPL v2" also.

-- 
Timur Tabi