From: Mahesh Jagannath Salgaonkar <mahesh@linux•vnet.ibm.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux•vnet.ibm.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs•org>,
Paul Mackerras <paulus@samba•org>,
Anton Blanchard <anton@samba•org>
Subject: Re: [PATCH] powerpc: Fix the corrupt r3 error during MCE handling.
Date: Thu, 11 Jul 2013 10:04:29 +0530 [thread overview]
Message-ID: <51DE35D5.5070005@linux.vnet.ibm.com> (raw)
In-Reply-To: <8761wild20.fsf@linux.vnet.ibm.com>
On 07/10/2013 07:41 PM, Aneesh Kumar K.V wrote:
> Mahesh J Salgaonkar <mahesh@linux•vnet.ibm.com> writes:
>
>> From: Mahesh Salgaonkar <mahesh@linux•vnet.ibm.com>
>>
>> During Machine Check interrupt on pseries platform, R3 generally points to
>> memory region inside RTAS (FWNMI) area. We see r3 corruption because when RTAS
>> delivers the machine check exception it passes the address inside FWNMI area
>> with the top most bit set. This patch fixes this issue by masking top two bit
>> in machine check exception handler.
>
> I always got that error and used to wonder why I find FWNMI
> corrupt. IS this a rtas bug or is it documented in papr ?
Nope. There is no mention of it in PAPR. It looks like a bug in RTAS.
>
>
>>
>> Signed-off-by: Mahesh Salgaonkar <mahesh@linux•vnet.ibm.com>
>> ---
>> arch/powerpc/platforms/pseries/ras.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
>> index 7b3cbde..721c058 100644
>> --- a/arch/powerpc/platforms/pseries/ras.c
>> +++ b/arch/powerpc/platforms/pseries/ras.c
>> @@ -287,6 +287,9 @@ static struct rtas_error_log *fwnmi_get_errinfo(struct pt_regs *regs)
>> unsigned long *savep;
>> struct rtas_error_log *h, *errhdr = NULL;
>>
>> + /* Mask top two bits */
>> + regs->gpr[3] &= ~(0x3UL << 62);
>> +
>> if (!VALID_FWNMI_BUFFER(regs->gpr[3])) {
>> printk(KERN_ERR "FWNMI: corrupt r3 0x%016lx\n", regs->gpr[3]);
>> return NULL;
>>
>
> -aneesh
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists•ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
next prev parent reply other threads:[~2013-07-11 4:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 13:02 [PATCH] powerpc: Fix the corrupt r3 error during MCE handling Mahesh J Salgaonkar
2013-07-10 14:11 ` Aneesh Kumar K.V
2013-07-11 4:34 ` Mahesh Jagannath Salgaonkar [this message]
2013-07-11 4:42 ` Benjamin Herrenschmidt
2013-07-11 5:54 ` Anshuman Khandual
2013-07-15 6:06 ` Aneesh Kumar K.V
2013-07-15 6:18 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DE35D5.5070005@linux.vnet.ibm.com \
--to=mahesh@linux$(echo .)vnet.ibm.com \
--cc=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=anton@samba$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox