From: Chen Gang <gang.chen@asianux•com>
To: "Srivatsa S. Bhat" <srivatsa.bhat@linux•vnet.ibm.com>
Cc: chenhui.zhao@freescale•com, "paulus@samba•org" <paulus@samba•org>,
Thomas Gleixner <tglx@linutronix•de>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH v2] powerpc: kernel: remove useless code which related with 'max_cpus'
Date: Mon, 22 Jul 2013 15:03:35 +0800 [thread overview]
Message-ID: <51ECD947.7010901@asianux.com> (raw)
In-Reply-To: <51ECD664.7040708@linux.vnet.ibm.com>
On 07/22/2013 02:51 PM, Srivatsa S. Bhat wrote:
> On 07/22/2013 12:10 PM, Chen Gang wrote:
>> Since not need 'max_cpus' after the related commit, the related code
>> are useless too, need be removed.
>>
>> The related commit:
>>
>> c1aa687 powerpc: Clean up obsolete code relating to decrementer and timebase
>>
>> The related warning:
>>
>> arch/powerpc/kernel/smp.c:323:43: warning: parameter ‘max_cpus’ set but not used [-Wunused-but-set-parameter]
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux•com>
>
> This version looks good.
>
> Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux•vnet.ibm.com>
>
Thank you very much.
> Regards,
> Srivatsa S. Bhat
>
>> ---
>> arch/powerpc/kernel/smp.c | 9 ++-------
>> 1 files changed, 2 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
>> index 38b0ba6..7edbd5b 100644
>> --- a/arch/powerpc/kernel/smp.c
>> +++ b/arch/powerpc/kernel/smp.c
>> @@ -346,13 +346,8 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
>> cpumask_set_cpu(boot_cpuid, cpu_sibling_mask(boot_cpuid));
>> cpumask_set_cpu(boot_cpuid, cpu_core_mask(boot_cpuid));
>>
>> - if (smp_ops)
>> - if (smp_ops->probe)
>> - max_cpus = smp_ops->probe();
>> - else
>> - max_cpus = NR_CPUS;
>> - else
>> - max_cpus = 1;
>> + if (smp_ops && smp_ops->probe)
>> + smp_ops->probe();
>> }
>>
>> void smp_prepare_boot_cpu(void)
>>
>
>
>
>
--
Chen Gang
next prev parent reply other threads:[~2013-07-22 7:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 5:58 [PATCH] powerpc: kernel: remove useless code which related with 'max_cpus' Chen Gang
2013-07-22 6:18 ` Srivatsa S. Bhat
2013-07-22 6:27 ` Chen Gang
2013-07-22 6:40 ` [PATCH v2] " Chen Gang
2013-07-22 6:51 ` Srivatsa S. Bhat
2013-07-22 7:03 ` Chen Gang [this message]
2013-07-23 13:44 ` Michael Ellerman
2013-07-24 0:28 ` Chen Gang
2013-07-24 1:16 ` Michael Ellerman
2013-07-24 2:09 ` Chen Gang
2013-07-25 3:15 ` Michael Ellerman
2013-07-25 4:02 ` Chen Gang
2013-07-25 5:16 ` Benjamin Herrenschmidt
2013-07-25 5:24 ` Chen Gang
2013-07-25 5:51 ` Benjamin Herrenschmidt
2013-07-25 6:03 ` Benjamin Herrenschmidt
2013-07-25 6:30 ` Chen Gang
2013-07-25 6:17 ` Chen Gang
2013-07-25 7:33 ` Benjamin Herrenschmidt
2013-07-25 7:59 ` Chen Gang
2013-07-25 8:06 ` Benjamin Herrenschmidt
2013-07-25 8:22 ` Chen Gang
2013-07-25 8:28 ` Benjamin Herrenschmidt
2013-07-25 8:36 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ECD947.7010901@asianux.com \
--to=gang.chen@asianux$(echo .)com \
--cc=chenhui.zhao@freescale$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=srivatsa.bhat@linux$(echo .)vnet.ibm.com \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox