From: Chen Gang <gang.chen@asianux•com>
To: Bjorn Helgaas <bhelgaas@google•com>
Cc: Richard Yang <weiyang@linux•vnet.ibm.com>,
Gavin Shan <shangw@linux•vnet.ibm.com>,
Ram Pai <linuxram@us•ibm.com>,
"paulus@samba•org" <paulus@samba•org>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH] powerpc: platforms: powernv: add '__init' for pnv_pci_init_ioda2_phb()
Date: Tue, 23 Jul 2013 08:37:28 +0800 [thread overview]
Message-ID: <51EDD048.1000404@asianux.com> (raw)
In-Reply-To: <CAErSpo6_537nW9+7MtLcA70HhiZwQG3TFCZCUumPk+b8GAgq3Q@mail.gmail.com>
On 07/23/2013 08:28 AM, Bjorn Helgaas wrote:
> On Mon, Jul 22, 2013 at 12:52 AM, Chen Gang <gang.chen@asianux•com> wrote:
>> pnv_pci_init_ioda2_phb() is only used during boot up, so need add
>> '__init' to save the related memory, and avoid related warning:
>>
>> The function .pnv_pci_init_ioda2_phb() references
>> the function __init .pnv_pci_init_ioda_phb().
>> This is often because .pnv_pci_init_ioda2_phb lacks a __init
>> annotation or the annotation of .pnv_pci_init_ioda_phb is wrong.
>>
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux•com>
>
> Looks right to me.
>
Thanks.
>> ---
>> arch/powerpc/platforms/powernv/pci-ioda.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
>> index 49b57b9..d8140b1 100644
>> --- a/arch/powerpc/platforms/powernv/pci-ioda.c
>> +++ b/arch/powerpc/platforms/powernv/pci-ioda.c
>> @@ -1266,7 +1266,7 @@ void __init pnv_pci_init_ioda_phb(struct device_node *np,
>> opal_pci_set_pe(phb_id, 0, 0, 7, 1, 1 , OPAL_MAP_PE);
>> }
>>
>> -void pnv_pci_init_ioda2_phb(struct device_node *np)
>> +void __init pnv_pci_init_ioda2_phb(struct device_node *np)
>> {
>> pnv_pci_init_ioda_phb(np, 0, PNV_PHB_IODA2);
>> }
>> --
>> 1.7.7.6
>
>
--
Chen Gang
prev parent reply other threads:[~2013-07-23 0:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 6:52 [PATCH] powerpc: platforms: powernv: add '__init' for pnv_pci_init_ioda2_phb() Chen Gang
2013-07-23 0:28 ` Bjorn Helgaas
2013-07-23 0:37 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EDD048.1000404@asianux.com \
--to=gang.chen@asianux$(echo .)com \
--cc=bhelgaas@google$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=linuxram@us$(echo .)ibm.com \
--cc=paulus@samba$(echo .)org \
--cc=shangw@linux$(echo .)vnet.ibm.com \
--cc=weiyang@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox