From: Zhang Haijun <B42677@freescale•com>
To: Haijun Zhang <Haijun.Zhang@freescale•com>
Cc: linux-mmc@vger•kernel.org, AFLEMING@freescale•com,
cbouatmailru@gmail•com, scottwood@freescale•com, cjb@laptop•org,
linuxppc-dev@lists•ozlabs.org,
Xie Xiaobo-R63061 <X.Xie@freescale•com>
Subject: Re: [PATCH 1/3 V2] mmc:core: parse voltage from device-tree
Date: Wed, 7 Aug 2013 09:28:35 +0800 [thread overview]
Message-ID: <5201A2C3.1080608@freescale.com> (raw)
In-Reply-To: <1375251927-3330-1-git-send-email-Haijun.Zhang@freescale.com>
On 07/31/2013 02:25 PM, Haijun Zhang wrote:
> Add function to support get voltage from device-tree.
> If there are voltage-range specified in device-tree node, this function
> will parse it and return the avail voltage mask.
>
> Signed-off-by: Haijun Zhang <haijun.zhang@freescale•com>
> ---
> changes for v2:
> - Update the parameters of function
>
> drivers/mmc/core/core.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
> include/linux/mmc/core.h | 1 +
> 2 files changed, 47 insertions(+)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index 49a5bca..ce9c957 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -27,6 +27,7 @@
> #include <linux/fault-inject.h>
> #include <linux/random.h>
> #include <linux/slab.h>
> +#include <linux/of.h>
>
> #include <linux/mmc/card.h>
> #include <linux/mmc/host.h>
> @@ -1196,6 +1197,51 @@ u32 mmc_vddrange_to_ocrmask(int vdd_min, int vdd_max)
> }
> EXPORT_SYMBOL(mmc_vddrange_to_ocrmask);
>
> +#ifdef CONFIG_OF
> +
> +/*
> + * mmc_of_parse_voltage - return mask of supported voltages
> + * @np: The device node need to be parsed.
> + *
> + * 1. Return zero: voltage-ranges unspecified in device-tree.
> + * 2. Return negative errno: voltage-range is invalid.
> + * 3. Return ocr_mask: a mask of voltages that parse from device-tree
> + * node can be provided to MMC/SD/SDIO devices.
> + */
> +
> +u32 mmc_of_parse_voltage(struct device_node *np)
> +{
> + const u32 *voltage_ranges;
> + int num_ranges, i;
> + u32 ocr_mask = 0;
> +
> + voltage_ranges = of_get_property(np, "voltage-ranges", &num_ranges);
> + num_ranges = num_ranges / sizeof(*voltage_ranges) / 2;
> + if (!voltage_ranges || !num_ranges) {
> + pr_info("%s: voltage-ranges unspecified\n", np->full_name);
> + return 0;
> + }
> +
> + for (i = 0; i < num_ranges; i++) {
> + const int j = i * 2;
> + u32 mask;
> +
> + mask = mmc_vddrange_to_ocrmask(be32_to_cpu(voltage_ranges[j]),
> + be32_to_cpu(voltage_ranges[j + 1]));
> + if (!mask) {
> + pr_err("%s: voltage-range #%d is invalid\n",
> + np->full_name, i);
> + return -EINVAL;
> + }
> + ocr_mask |= mask;
> + }
> +
> + return ocr_mask;
> +}
> +EXPORT_SYMBOL(mmc_of_parse_voltage);
> +
> +#endif /* CONFIG_OF */
> +
> #ifdef CONFIG_REGULATOR
>
> /**
> diff --git a/include/linux/mmc/core.h b/include/linux/mmc/core.h
> index 443243b..e3f8fe3 100644
> --- a/include/linux/mmc/core.h
> +++ b/include/linux/mmc/core.h
> @@ -209,5 +209,6 @@ static inline void mmc_claim_host(struct mmc_host *host)
> }
>
> extern u32 mmc_vddrange_to_ocrmask(int vdd_min, int vdd_max);
> +extern u32 mmc_of_parse_voltage(struct device_node *np);
>
> #endif /* LINUX_MMC_CORE_H */
Hi, Anton
Could you give some advice for this patch set?
--
Thanks & Regards
Haijun
next prev parent reply other threads:[~2013-08-07 1:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 6:25 [PATCH 1/3 V2] mmc:core: parse voltage from device-tree Haijun Zhang
2013-07-31 6:25 ` [PATCH 3/3 V2] mmc:esdhc: add support to get " Haijun Zhang
2013-07-31 6:25 ` [PATCH] mmc:of_spi: Update the code of getting voltage-ranges Haijun Zhang
2013-08-09 0:08 ` Anton Vorontsov
2013-08-07 1:28 ` Zhang Haijun [this message]
2013-08-09 0:15 ` [PATCH 1/3 V2] mmc:core: parse voltage from device-tree Anton Vorontsov
2013-08-09 3:34 ` Zhang Haijun
2013-08-09 14:48 ` Kumar Gala
2013-08-12 2:46 ` Zhang Haijun
2013-08-12 16:11 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5201A2C3.1080608@freescale.com \
--to=b42677@freescale$(echo .)com \
--cc=AFLEMING@freescale$(echo .)com \
--cc=Haijun.Zhang@freescale$(echo .)com \
--cc=X.Xie@freescale$(echo .)com \
--cc=cbouatmailru@gmail$(echo .)com \
--cc=cjb@laptop$(echo .)org \
--cc=linux-mmc@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox