From: Segher Boessenkool <segher@kernel•crashing.org>
To: will_schmidt@vnet•ibm.com
Cc: willschm@linux•vnet.ibm.com,
LinuxPPC-dev <linuxppc-dev@ozlabs•org>,
Paul Mackerras <paulus@samba•org>
Subject: Re: [PATCH v2.1 ] Fix VDSO gettimeofday() when called with NULL struct timeval.
Date: Sat, 30 Jun 2007 00:45:47 +0200 [thread overview]
Message-ID: <5204a94ef7649d5ebc72df2eb93db6e0@kernel.crashing.org> (raw)
In-Reply-To: <1183150190.22547.62.camel@farscape.rchland.ibm.com>
> The vdso64 portion of patch 74609f4536f2b8fd6a48381bbbe3cd37da20a527
> for
> fixing problems with NULL gettimeofday input mistakenly checks for a
> null tz field twice, when it should be checking for null tz once, and
> null tv once; by way of a r10/r11 typo.
>
> Any application calling gettimeofday(&tv,NULL) will "fail".
>
> This corrects that typo, and makes my G5 happy.
>
> tested on G5.
>
>
> Signed-off-by: Will Schmidt <will_schmidt@vnet•ibm.com>
Obviously correct, how could we all have missed this :-(
Thanks Will.
Segher
next prev parent reply other threads:[~2007-06-29 22:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 10:58 [PATCH] Fix VDSO gettimeofday() when called with NULL struct timeval Tony Breeds
2007-06-25 12:39 ` Benjamin Herrenschmidt
2007-06-25 23:37 ` Tony Breeds
2007-06-25 13:35 ` Segher Boessenkool
2007-06-25 23:39 ` Tony Breeds
2007-06-25 23:50 ` [PATCH v2] " Tony Breeds
2007-06-26 1:55 ` Benjamin Herrenschmidt
2007-06-26 7:55 ` Segher Boessenkool
2007-06-29 20:39 ` Will Schmidt
2007-06-29 20:49 ` [PATCH v2.1 ] " Will Schmidt
2007-06-29 22:45 ` Segher Boessenkool [this message]
2007-07-02 23:20 ` Tony Breeds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5204a94ef7649d5ebc72df2eb93db6e0@kernel.crashing.org \
--to=segher@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=will_schmidt@vnet$(echo .)ibm.com \
--cc=willschm@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox