From: Stephen Warren <swarren@wwwdotorg•org>
To: Nicolin Chen <b42378@freescale•com>
Cc: mark.rutland@arm•com, devicetree@vger•kernel.org,
alsa-devel@alsa-project•org, lars@metafoo•de, festevam@gmail•com,
s.hauer@pengutronix•de, timur@tabi•org, rob.herring@calxeda•com,
tomasz.figa@gmail•com, broonie@kernel•org,
p.zabel@pengutronix•de, R65777@freescale•com,
shawn.guo@linaro•org, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v10 2/2] ASoC: fsl: Add S/PDIF machine driver
Date: Wed, 21 Aug 2013 12:30:59 -0600 [thread overview]
Message-ID: <52150763.8020707@wwwdotorg.org> (raw)
In-Reply-To: <e9cf5e37f858dea78319720f007f66c8c063885f.1377054540.git.b42378@freescale.com>
On 08/20/2013 09:13 PM, Nicolin Chen wrote:
> This patch implements a device-tree-only machine driver for Freescale
> i.MX series Soc. It works with spdif_transmitter/spdif_receiver and
> fsl_spdif.c drivers.
> diff --git a/Documentation/devicetree/bindings/sound/imx-audio-spdif.txt b/Documentation/devicetree/bindings/sound/imx-audio-spdif.txt
> +Optional properties:
> +
> + - spdif-transmitter : The phandle of the spdif-transmitter codec
> +
> + - spdif-receiver : The phandle of the spdif-receiver codec
> +
> +* Note: At least one of these two properties should be set in the DT binding.
I still don't think those two properties are correct.
Exactly what node will those phandles point at?
There definitely should not be a DT node for any "dummy CODEC",
irrespective of whether this binding calls the other node a "CODEC" or a
"dummy CODEC".
If these properties are to contain phandles, it would be acceptable for
the referenced node to be:
* A node representing the physical connector/jack on the board.
* A node representing some other IP block on the board, such as an HDMI
encoder/display-controller
I think those options are unlikely in general, so I think instead these
properties should just be Boolean indicating that "something" is
connector to the S/PDIF RX/TX, without specifying what that "something"
is. It doesn't matter what at least in the connector/jack case, although
perhaps it does in the HDMI encoder/display-controller?
next prev parent reply other threads:[~2013-08-21 18:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 3:13 [PATCH v10 0/2] Add freescale S/PDIF CPU DAI and machine drivers Nicolin Chen
2013-08-21 3:13 ` [PATCH v10 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver Nicolin Chen
2013-08-21 18:26 ` Stephen Warren
2013-08-22 9:45 ` Mark Brown
2013-08-21 3:13 ` [PATCH v10 2/2] ASoC: fsl: Add S/PDIF machine driver Nicolin Chen
2013-08-21 18:30 ` Stephen Warren [this message]
2013-08-21 18:54 ` Tomasz Figa
2013-08-21 22:14 ` Stephen Warren
2013-08-22 11:40 ` Nicolin Chen
2013-08-22 19:56 ` Stephen Warren
2013-08-22 20:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52150763.8020707@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=R65777@freescale$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=b42378@freescale$(echo .)com \
--cc=broonie@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=festevam@gmail$(echo .)com \
--cc=lars@metafoo$(echo .)de \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=rob.herring@calxeda$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawn.guo@linaro$(echo .)org \
--cc=timur@tabi$(echo .)org \
--cc=tomasz.figa@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox