From: Stephen Warren <swarren@wwwdotorg•org>
To: Hongbo Zhang <hongbo.zhang@freescale•com>
Cc: mark.rutland@arm•com, devicetree@vger•kernel.org,
ian.campbell@citrix•com, pawel.moll@arm•com,
vinod.koul@intel•com, linux-kernel@vger•kernel.org,
rob.herring@calxeda•com, djbw@fb•com,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v10 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes
Date: Tue, 24 Sep 2013 11:31:12 -0600 [thread overview]
Message-ID: <5241CC60.5070204@wwwdotorg.org> (raw)
In-Reply-To: <524169E3.7030408@freescale.com>
On 09/24/2013 04:30 AM, Hongbo Zhang wrote:
> On 09/24/2013 01:04 AM, Stephen Warren wrote:
>> On 09/18/2013 04:15 AM, hongbo.zhang@freescale•com wrote:
>>> From: Hongbo Zhang <hongbo.zhang@freescale•com>
>>>
>>> Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines, this
>>> patch adds
>>> the device tree nodes for them.
>>> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/dma.txt
>>> b/Documentation/devicetree/bindings/powerpc/fsl/dma.txt
>>> +Required properties:
>>> +
>>> +- compatible : must include "fsl,elo3-dma"
>>> +- reg : DMA General Status Registers, i.e. DGSR0 which
>>> contains
>>> + status for channel 1~4, and DGSR1 for channel 5~8
>> Is that a single entry, which is large enough to cover both registers,
>> or a pair of entries, one per register? Reading the text, I might assume
>> the former, but looking at the examples, it's the latter.
> My impression is that I cannot tell it is one larger entry or two
> entries by reading the description text, but the example gives the answer.
> Is it so important to specify it is only one entry or entries list?
> I prefer language as concise as possible, especially for the common
> properties such as reg and interrupt (eg the reg is implicitly offset
> and length of registers, can be continuous or not), it is difficult or
> unnecessary or impossible to describe much details, the example can also
> work as a complementary description, otherwise no need to put an example
> in the binding document.
The description of the properties should fully describe them. The
example is just an example, not a specification of the properties.
next prev parent reply other threads:[~2013-09-24 17:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 10:15 [PATCH v10 0/3] DMA: Freescale: Add support for 8-channel DMA engine hongbo.zhang
2013-09-18 10:15 ` [PATCH v10 1/3] DMA: Freescale: revise device tree binding document hongbo.zhang
2013-09-18 10:15 ` [PATCH v10 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes hongbo.zhang
2013-09-23 17:04 ` Stephen Warren
2013-09-24 10:30 ` Hongbo Zhang
2013-09-24 17:31 ` Stephen Warren [this message]
2013-09-25 7:35 ` Hongbo Zhang
2013-09-26 1:46 ` Scott Wood
2013-09-26 2:28 ` David Gibson
2013-09-26 5:06 ` Hongbo Zhang
2013-09-18 10:15 ` [PATCH v10 3/3] DMA: Freescale: update driver to support 8-channel DMA engine hongbo.zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5241CC60.5070204@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=djbw@fb$(echo .)com \
--cc=hongbo.zhang@freescale$(echo .)com \
--cc=ian.campbell@citrix$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=pawel.moll@arm$(echo .)com \
--cc=rob.herring@calxeda$(echo .)com \
--cc=vinod.koul@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox