From: Timur Tabi <timur@tabi•org>
To: Nicolin Chen <b42378@freescale•com>,
s.hauer@pengutronix•de, shawn.guo@linaro•org, broonie@kernel•org
Cc: mark.rutland@arm•com, devicetree@vger•kernel.org,
alsa-devel@alsa-project•org, pawel.moll@arm•com,
linux-doc@vger•kernel.org, swarren@wwwdotorg•org,
linux-kernel@vger•kernel.org, rob.herring@calxeda•com,
philippe.retornaz@gmail•com, galak@codeaurora•org,
dmaengine@vger•kernel.org, ijc+devicetree@hellion•org.uk,
linuxppc-dev@lists•ozlabs.org,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v3 3/4] ASoC: fsl_ssi: Add dual fifo mode support
Date: Thu, 31 Oct 2013 07:04:29 -0500 [thread overview]
Message-ID: <5272474D.5000207@tabi.org> (raw)
In-Reply-To: <da997ce67d9817364248ca1eba716bb6c7814a24.1383207153.git.b42378@freescale.com>
Nicolin Chen wrote:
> + if (ssi_private->use_dual_fifo) {
> + write_ssi_mask(&ssi->srcr, 0, CCSR_SSI_SRCR_RFEN1);
> + write_ssi_mask(&ssi->stcr, 0, CCSR_SSI_STCR_TFEN1);
> + write_ssi_mask(&ssi->scr, 0, CCSR_SSI_SCR_TCH_EN);
> + } else {
> + write_ssi_mask(&ssi->srcr, CCSR_SSI_SRCR_RFEN1, 0);
> + write_ssi_mask(&ssi->stcr, CCSR_SSI_STCR_TFEN1, 0);
> + write_ssi_mask(&ssi->scr, CCSR_SSI_SCR_TCH_EN, 0);
> + }
Why do you need the "else" part? Why can't you just do this:
if (ssi_private->use_dual_fifo) {
write_ssi_mask(&ssi->srcr, 0, CCSR_SSI_SRCR_RFEN1);
write_ssi_mask(&ssi->stcr, 0, CCSR_SSI_STCR_TFEN1);
write_ssi_mask(&ssi->scr, 0, CCSR_SSI_SCR_TCH_EN);
}
next prev parent reply other threads:[~2013-10-31 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 8:22 [PATCH v3 0/4] Add dual-fifo mode support of i.MX ssi Nicolin Chen
2013-10-31 8:22 ` [PATCH v3 1/4] dma: imx-sdma: Add sdma firmware version 2 support Nicolin Chen
2013-10-31 8:22 ` [PATCH v3 2/4] dma: imx-sdma: Add new dma type for ssi dual fifo script Nicolin Chen
2013-10-31 8:22 ` [PATCH v3 3/4] ASoC: fsl_ssi: Add dual fifo mode support Nicolin Chen
2013-10-31 12:04 ` Timur Tabi [this message]
2013-10-31 12:28 ` Chen Guangyu-B42378
2013-10-31 8:22 ` [PATCH v3 4/4] ARM: dts: imx: use dual-fifo sdma script for ssi Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5272474D.5000207@tabi.org \
--to=timur@tabi$(echo .)org \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=b42378@freescale$(echo .)com \
--cc=broonie@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dmaengine@vger$(echo .)kernel.org \
--cc=galak@codeaurora$(echo .)org \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=pawel.moll@arm$(echo .)com \
--cc=philippe.retornaz@gmail$(echo .)com \
--cc=rob.herring@calxeda$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawn.guo@linaro$(echo .)org \
--cc=swarren@wwwdotorg$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox