From: Matteo Facchinetti <matteo.facchinetti@sirius-es•it>
To: Gerhard Sittig <gsi@denx•de>,
linuxppc-dev@lists•ozlabs.org, Anatolij Gustschin <agust@denx•de>,
Mike Turquette <mturquette@linaro•org>
Cc: Scott Wood <scottwood@freescale•com>, Detlev Zundel <dzu@denx•de>
Subject: Re: [PATCH v1 0/4] powerpc/512x: update COMMON_CLK support for MPC5125
Date: Thu, 12 Dec 2013 17:12:36 +0100 [thread overview]
Message-ID: <52A9E074.5080607@sirius-es.it> (raw)
In-Reply-To: <1386681097-14126-1-git-send-email-gsi@denx.de>
On 10/12/2013 14:11, Gerhard Sittig wrote:
> this series improves the previously introduced common clock support for
> MPC512x such that SoC variants 5123 and 5125 get addressed appropriately
> (MPC5125 turned out to be rather different from MPC5121 than I perceived
> before -- there is much more than "just two FECs and no MBX")
Ohhh yesss..... welcome to hell! :-)
I report also these differences:
- I/O control module:
to do integration with linux pin-muxing subsystem
- GPIO module:
controller is the same of the mpc5121 but with these differences:
- 64 gpios divided in 2 banks
- input only gpios are numbers form 0 to 3 of the first bank
I'm finishing to write the patch... when done I'll post in ML
- NFC: one of the biggest unsolved mystery
Is this ip-core used in others microcontrollers? Seems to be
used only in mpc5125!!!
>
> Matteo, can you verify the crystal frequency in the DTS update, please?
Crystal frequency is ok: 33MHz.
> And that v3.13-rc kernels with v6 of the COMMON_CLK introduction for
> MPC512x plus this series for MPC5125 operate your peripherals, both with
> an updated device tree as well as with a former device tree that lacks
> clock specs? Thank you! Setting CONFIG_COMMON_CLK_DEBUG=y in your
> .config and eyeballing /sys/kernel/debug/clk/clk_summary will help you.
>
>
I tested all on TWR board.
In DTS, for the moment, have to comment out this block:
- usb@3000 {
- compatible = "fsl,mpc5121-usb2-dr";
- reg = <0x3000 0x400>;
- #address-cells = <1>;
- #size-cells = <0>;
- interrupts = <43 0x8>;
- dr_mode = "host";
- phy_type = "ulpi";
- clocks = <&clks MPC512x_CLK_USB1>;
- clock-names = "ipg";
- };
Because USB controller pinout is not initialized correctly and when
system boot, causes a kernel panic.
For the rest, kernel works correctly. For MPC5125 the patches are OK.
I also check clk_summary and all clocks values are OK (except for NFC
clock value).
I notice that there are missing clock like: gpio1, gpio2, fuse, dma,
wdt, pmc, rtc.
Is this OK or should be added?
Regards,
Matteo Facchinetti
Sirius Electronic Systems
next prev parent reply other threads:[~2013-12-12 16:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 13:11 [PATCH v1 0/4] powerpc/512x: update COMMON_CLK support for MPC5125 Gerhard Sittig
2013-12-10 13:11 ` [PATCH v1 1/4] powerpc/512x: clk: minor comment updates Gerhard Sittig
2013-12-10 13:11 ` [PATCH v1 2/4] powerpc/512x: clk: enforce even SDHC divider values Gerhard Sittig
2013-12-10 13:11 ` [PATCH v1 3/4] powerpc/512x: clk: support MPC5121/5123/5125 SoC variants Gerhard Sittig
2013-12-10 13:11 ` [PATCH v1 4/4] powerpc/512x: dts: add MPC5125 clock specs Gerhard Sittig
2013-12-12 16:12 ` Matteo Facchinetti [this message]
2013-12-12 17:46 ` [PATCH v1 0/4] powerpc/512x: update COMMON_CLK support for MPC5125 Sinan Akman
2013-12-12 19:32 ` Scott Wood
2013-12-13 0:29 ` Sinan Akman
2013-12-12 22:25 ` Gerhard Sittig
2013-12-18 19:53 ` Anatolij Gustschin
2013-12-18 22:20 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A9E074.5080607@sirius-es.it \
--to=matteo.facchinetti@sirius-es$(echo .)it \
--cc=agust@denx$(echo .)de \
--cc=dzu@denx$(echo .)de \
--cc=gsi@denx$(echo .)de \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mturquette@linaro$(echo .)org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox