Subject: Re: [PATCH 1/2] video/fsl: make the diu driver work without platform hooks

From: Timur Tabi <[email-masked]>
Date: Wed, 26 Mar 2014 22:35:50 -0500

[email-masked] wrote:
>>>>> However, the DIU is already initialized in u-boot and we can
>>>>> rely on the settings in u-boot for corenet platform,
>>>
>>> I don't like that at all.
> [Jason Jin-R64188] What's the potential issue of this? Most of the
> IPs need the platform initialization in u-boot. For example, the
> hwconfig in u-boot used for board specific settings for most
> platform.

The potential problem is that it's not stable.  Power management breaks 
your code.

I won't NACK your patch, but it feels like a band-aid rather than a real 
solution.