Subject: Re: [1/2, v9] powerpc/mpc85xx:Add initial device tree support of T104x

From: Prabhakar Kushwaha <[email-masked]>
Date: Sun, 6 Apr 2014 18:48:15 +0530

On 3/20/2014 4:03 AM, Scott Wood wrote:
> On Sat, Jan 25, 2014 at 05:10:59PM +0530, Prabhakar Kushwaha wrote:
>> +	corenet-cf@18000 {
>> +		compatible = "fsl,corenet-cf";
>> +		reg = <0x18000 0x1000>;
>> +		interrupts = <16 2 1 31>;
>> +		fsl,ccf-num-csdids = <32>;
>> +		fsl,ccf-num-snoopids = <32>;
>> +	};
> I know this isn't a new problem, but this needs a binding -- and a
> different compatible from p4080-era CCF.  AFAICT it's a completely
> different programming model, and even the block version registers weren't
> present in the original version.

No binding present for corenet-cf looks like new binding needs to be 
sent with possible compatabile.

>> +/include/ "qoriq-mpic.dtsi"
>> +
>> +	guts: global-utilities@e0000 {
>> +		compatible = "fsl,t1040-device-config", "fsl,qoriq-device-config-2.0";
>> +		reg = <0xe0000 0xe00>;
>> +		fsl,has-rstcr;
>> +		fsl,liodn-bits = <12>;
>> +	};
>> +
>> +	clockgen: global-utilities@e1000 {
>> +		compatible = "fsl,t1040-clockgen", "fsl,qoriq-clockgen-2.0",
>> +				   "fixed-clock";
>> +		ranges = <0x0 0xe1000 0x1000>;
>> +		clock-frequency = <100000000>;
> Why is clock-frequency hardcoded here rather than supplied by U-Boot?
> Especially since this is an SoC file, not a board file.

Your are correct.
Means, clock-frequency should be added to clockgen in board device tree ??

>> +		reg = <0xe1000 0x1000>;
>> +		clock-output-names = "sysclk";
>> +		#address-cells = <1>;
>> +		#size-cells = <1>;
> clock-output-names and fixed-clock doesn't belong on this node.

Yes, clock-output-names and fixed-clock should be present in sysclk node.

>
>> +
>> +		sysclk: sysclk {
>> +			#clock-cells = <0>;
>> +			compatible = "fsl,qoriq-sysclk-2.0";
>> +			clock-output-names = "sysclk";
>> +		};
>> +
>> +
>> +		pll0: pll0@800 {
>> +			#clock-cells = <1>;
>> +			reg = <0x800 4>;
>> +			compatible = "fsl,qoriq-core-pll-2.0";
>> +			clocks = <&clockgen>;
>> +			clock-output-names = "pll0", "pll0-div2", "pll0-div4";
>> +		};
>> +
>> +		pll1: pll1@820 {
>> +			#clock-cells = <1>;
>> +			reg = <0x820 4>;
>> +			compatible = "fsl,qoriq-core-pll-2.0";
>> +			clocks = <&clockgen>;
>> +			clock-output-names = "pll1", "pll1-div2", "pll1-div4";
>> +		};
> clocks should point to sysclk.

got it!!

>
>> +	display@180000 {
>> +		compatible = "fsl,t1040-diu", "fsl,diu";
>> +		reg = <0x180000 1000>;
>> +		interrupts = <74 2 0 0>;
>> +	};
>> +
>> +/include/ "qoriq-sata2-0.dtsi"
>> +sata@220000 {
>> +			fsl,iommu-parent = <&pamu0>;
>> +			fsl,liodn-reg = <&guts 0x550>; /* SATA1LIODNR */
>> +};
>> +/include/ "qoriq-sata2-1.dtsi"
>> +sata@221000 {
>> +			fsl,iommu-parent = <&pamu0>;
>> +			fsl,liodn-reg = <&guts 0x554>; /* SATA2LIODNR */
>> +};
>> +/include/ "qoriq-sec5.0-0.dtsi"
>> +};
> Whitespace
>
>
i did not find this whitespace :(

Regards,
Prabhakar