From: Segher Boessenkool <segher@kernel•crashing.org>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org, David Gibson <david@gibson•dropbear.id.au>
Subject: Re: [PATCH 15/16] Add device tree for Ebony
Date: Wed, 14 Feb 2007 18:51:27 +0100 [thread overview]
Message-ID: <536d4ad153f9c23c817640bfd09b542b@kernel.crashing.org> (raw)
In-Reply-To: <1171417866.20192.126.camel@localhost.localdomain>
>>>> + UIC0: interrupt-controller { /* UIC0 */
>>>
>>>> + #address-cells = <0>;
>>>> + #size-cells = <0>;
>>>
>>> #address-cells = 0 never makes sense.
>>
>> Why not? Children of this node have and need no reg property, and no
>> meaningful address. Sounds like #address-cells = 0 to me.
>
> In fact, not only it does make perfect sense but it's also routinely
> used for ... interrupt controllers :-) That's among others why the
> interrupt map entries "second" part usually doesn't contain the address
> cells.
Can you please explain this in detail? Children of such
a node (a node with #a = 0) have no "reg" property --
maybe something in the interrupt tree stuff still needs
a #a in the interrupt controller node, but I fail to
see what right now.
>>> You need a #address-cells, #size-cells here.
>>
>> Why? The values inherited from the root node are perfectly ok here.
>
> Inheriting values is out of spec.
It's not just out of spec but directly contradicting it.
> The kernel somewhat does it but that's
> a bad habit, we should always have them explicit.
The kernel should really only do it on firmwares that
need this quirk. Alternatively, some early fix up
pass could add the properties on such a firmware.
Segher
next prev parent reply other threads:[~2007-02-14 17:51 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-13 6:09 [0/16] Preliminary Ebony (440GP) support for arch/powerpc David Gibson
2007-02-13 6:10 ` [PATCH 8/16] Define FIXED_PORT flag for serial_core David Gibson
2007-02-13 6:10 ` [PATCH 2/16] More DCR native fixups David Gibson
2007-02-13 6:22 ` Benjamin Herrenschmidt
2007-02-13 6:10 ` [PATCH 6/16] Port 44x MMU definitions to ARCH=powerpc David Gibson
2007-02-13 6:24 ` Benjamin Herrenschmidt
2007-02-13 17:13 ` Roland Dreier
2007-02-13 17:45 ` Josh Boyer
2007-02-13 21:36 ` Benjamin Herrenschmidt
2007-02-13 6:10 ` [PATCH 4/16] powerpc: Allow duplicate lmb_reserve() calls David Gibson
2007-02-13 7:05 ` Michael Neuling
2007-02-13 8:48 ` Michael Ellerman
2007-02-13 20:44 ` Benjamin Herrenschmidt
2007-02-13 6:10 ` [PATCH 7/16] Early serial debug support for PPC44x David Gibson
2007-02-13 15:04 ` Josh Boyer
2007-02-14 0:16 ` David Gibson
2007-02-14 1:02 ` Josh Boyer
2007-02-14 1:00 ` David Gibson
2007-02-14 2:00 ` Alan Modra
2007-02-14 2:02 ` David Gibson
2007-02-14 2:38 ` Alan Modra
2007-02-14 15:41 ` Josh Boyer
2007-02-14 23:05 ` David Gibson
2007-02-13 6:10 ` [PATCH 3/16] [powerpc] Use udbg_early_init() on ppc32 David Gibson
2007-02-13 6:22 ` Benjamin Herrenschmidt
2007-02-13 6:10 ` [PATCH 1/16] Remove ibm4{xx,4x}.h from arch/powerpc David Gibson
2007-02-13 14:19 ` Josh Boyer
2007-02-13 6:10 ` [PATCH 5/16] powerpc: Add zImage platform hook for kernel address David Gibson
2007-02-13 6:10 ` [PATCH 9/16] Use resource_size_t for serial port IO addresses David Gibson
2007-02-13 6:10 ` [PATCH 13/16] Add initrd properties to device tree from zImage David Gibson
2007-02-13 6:10 ` [PATCH 14/16] Add arch/powerpc driver for UIC, PPC4xx interrupt controller David Gibson
2007-02-13 6:10 ` [PATCH 11/16] zImage wrapper for Ebony David Gibson
2007-02-13 17:05 ` Geoff Levand
2007-02-14 0:17 ` David Gibson
2007-02-13 6:10 ` [PATCH 10/16] Add support for BSS stack for zImage wrapper David Gibson
2007-02-13 6:10 ` [PATCH 12/16] Automatically lmb_reserve() initrd David Gibson
2007-02-13 7:14 ` Michael Neuling
2007-02-13 6:10 ` [PATCH 15/16] Add device tree for Ebony David Gibson
2007-02-13 20:08 ` Segher Boessenkool
2007-02-14 0:22 ` David Gibson
2007-02-14 1:51 ` Benjamin Herrenschmidt
2007-02-14 4:46 ` David Gibson
2007-02-14 17:54 ` Segher Boessenkool
2007-02-14 23:18 ` David Gibson
2007-02-15 0:25 ` Segher Boessenkool
2007-02-14 17:51 ` Segher Boessenkool [this message]
2007-02-14 17:48 ` Segher Boessenkool
2007-02-14 21:30 ` Benjamin Herrenschmidt
2007-02-15 0:03 ` Segher Boessenkool
2007-02-15 0:53 ` Benjamin Herrenschmidt
2007-02-15 1:00 ` Segher Boessenkool
2007-02-15 2:22 ` Benjamin Herrenschmidt
2007-02-15 2:51 ` Segher Boessenkool
2007-02-14 23:17 ` David Gibson
2007-02-15 0:27 ` Segher Boessenkool
2007-02-15 14:02 ` Jon Loeliger
2007-02-15 14:56 ` Segher Boessenkool
2007-02-15 17:02 ` Yoder Stuart-B08248
2007-02-15 17:10 ` Scott Wood
2007-02-16 9:20 ` Segher Boessenkool
2007-02-14 16:14 ` Yoder Stuart-B08248
2007-02-14 16:32 ` Josh Boyer
2007-02-14 17:58 ` Segher Boessenkool
2007-02-14 20:08 ` Yoder Stuart-B08248
2007-02-14 21:12 ` Segher Boessenkool
2007-02-14 21:35 ` Yoder Stuart-B08248
2007-02-14 21:42 ` Benjamin Herrenschmidt
2007-02-14 21:59 ` Scott Wood
2007-02-15 0:20 ` Segher Boessenkool
2007-02-14 22:50 ` Yoder Stuart-B08248
2007-02-14 22:57 ` Benjamin Herrenschmidt
2007-02-15 0:17 ` Segher Boessenkool
2007-02-15 2:12 ` Paul Mackerras
2007-02-15 2:43 ` Segher Boessenkool
2007-02-15 3:15 ` Paul Mackerras
2007-02-15 14:40 ` Segher Boessenkool
2007-02-16 1:17 ` Paul Mackerras
2007-02-16 9:41 ` Segher Boessenkool
2007-02-15 0:10 ` Segher Boessenkool
2007-02-14 23:32 ` David Gibson
2007-02-14 23:27 ` David Gibson
2007-02-14 23:22 ` David Gibson
2007-02-14 23:51 ` Benjamin Herrenschmidt
2007-02-15 0:36 ` Segher Boessenkool
2007-02-15 0:31 ` Segher Boessenkool
2007-02-15 1:53 ` David Gibson
2007-02-15 3:09 ` Segher Boessenkool
2007-02-15 3:33 ` David Gibson
2007-02-15 14:47 ` Segher Boessenkool
2007-02-15 10:52 ` Benjamin Herrenschmidt
2007-02-15 14:52 ` Segher Boessenkool
2007-02-15 20:43 ` Benjamin Herrenschmidt
2007-02-16 9:23 ` Segher Boessenkool
2007-02-15 16:37 ` Yoder Stuart-B08248
2007-02-15 21:41 ` Benjamin Herrenschmidt
2007-02-16 9:25 ` Segher Boessenkool
2007-02-16 15:32 ` Hartmut Penner
2007-02-16 16:47 ` Yoder Stuart-B08248
2007-02-19 12:02 ` Hartmut Penner
2007-02-14 21:29 ` Benjamin Herrenschmidt
2007-02-13 6:10 ` [PATCH 16/16] Support for Ebony in arch/powerpc David Gibson
2007-02-13 17:18 ` Roland Dreier
2007-02-14 0:20 ` David Gibson
2007-02-13 14:37 ` [0/16] Preliminary Ebony (440GP) support for arch/powerpc Josh Boyer
2007-02-13 20:21 ` Josh Boyer
2007-02-13 15:46 ` Josh Boyer
2007-02-14 16:06 ` Josh Boyer
2007-02-14 23:12 ` David Gibson
2007-02-16 2:19 ` Josh Boyer
2007-02-16 2:53 ` David Gibson
2007-02-16 4:33 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536d4ad153f9c23c817640bfd09b542b@kernel.crashing.org \
--to=segher@kernel$(echo .)crashing.org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox