From: Alexander Graf <agraf@suse•de>
To: Gavin Shan <gwshan@linux•vnet.ibm.com>,
Alex Williamson <alex.williamson@redhat•com>
Cc: aik@ozlabs•ru, qiudayu@linux•vnet.ibm.com,
linuxppc-dev@lists•ozlabs.org, kvm-ppc@vger•kernel.org
Subject: Re: [PATCH 3/8] drivers/vfio: New IOCTL command VFIO_EEH_INFO
Date: Tue, 20 May 2014 12:02:22 +0200 [thread overview]
Message-ID: <537B282E.6040107@suse.de> (raw)
In-Reply-To: <20140520082856.GA16050@shangw>
On 20.05.14 10:28, Gavin Shan wrote:
> On Mon, May 19, 2014 at 06:37:24PM -0600, Alex Williamson wrote:
>> On Tue, 2014-05-20 at 10:22 +1000, Gavin Shan wrote:
>>> On Mon, May 19, 2014 at 04:33:10PM -0600, Alex Williamson wrote:
>>>> On Wed, 2014-05-14 at 14:11 +1000, Gavin Shan wrote:
>>>>> The patch adds new IOCTL command VFIO_EEH_INFO to VFIO container
>>>>> to support EEH functionality for PCI devices, which have been
>>>>> passed from host to guest via VFIO.
[...]
>>> diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h
>>> index cb9023d..1fd1bfb 100644
>>> --- a/include/uapi/linux/vfio.h
>>> +++ b/include/uapi/linux/vfio.h
>>> @@ -455,6 +455,63 @@ struct vfio_iommu_spapr_tce_info {
>>>
>>> #define VFIO_IOMMU_SPAPR_TCE_GET_INFO _IO(VFIO_TYPE, VFIO_BASE + 12)
>>>
>>> +/*
>>> + * The VFIO EEH info struct provides way to support EEH functionality
>>> + * for PCI device that is passed from host to guest via VFIO.
>>> + */
>>> +#define VFIO_EEH_OP_MAP 0
>>> +#define VFIO_EEH_OP_UNMAP 1
>>> +#define VFIO_EEH_OP_SET_OPTION 2
>>> +#define VFIO_EEH_OP_GET_ADDR 3
>>> +#define VFIO_EEH_OP_GET_STATE 4
>>> +#define VFIO_EEH_OP_PE_RESET 5
>>> +#define VFIO_EEH_OP_PE_CONFIG 6
>>>> Is this really an "info" ioctl?
>>>>
>>> Yeah, "VFIO_EEH_INFO" isn't a good name. How about to have "VFIO_EEH_HANDLER" ?
>> VFIO_EEH_OP perhaps. Thanks,
>>
> Ok. Will rename it to VFIO_EEH_OP in next revision.
Is there any benefit of a multiplexing EEH ioctl over just 7 individual
ioctls?
Alex
next prev parent reply other threads:[~2014-05-20 10:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 4:11 [PATCH RFC v3 0/8] EEH Support for VFIO PCI device Gavin Shan
2014-05-14 4:11 ` [PATCH 1/8] drivers/vfio: Introduce CONFIG_VFIO_EEH Gavin Shan
2014-05-14 4:11 ` [PATCH 2/8] powerpc/eeh: Info to trace passed devices Gavin Shan
2014-05-19 12:46 ` Alexander Graf
2014-05-19 22:37 ` Benjamin Herrenschmidt
2014-05-19 23:54 ` Gavin Shan
2014-05-14 4:11 ` [PATCH 3/8] drivers/vfio: New IOCTL command VFIO_EEH_INFO Gavin Shan
2014-05-19 12:51 ` Alexander Graf
2014-05-19 23:57 ` Gavin Shan
2014-05-19 22:33 ` Alex Williamson
2014-05-19 22:51 ` Benjamin Herrenschmidt
2014-05-20 0:22 ` Gavin Shan
2014-05-20 0:37 ` Alex Williamson
2014-05-20 8:28 ` Gavin Shan
2014-05-20 10:02 ` Alexander Graf [this message]
2014-05-20 10:23 ` Gavin Shan
2014-05-14 4:11 ` [PATCH 4/8] powerpc/eeh: Avoid event on passed PE Gavin Shan
2014-05-14 4:11 ` [PATCH 5/8] powerpc/powernv: Sync OPAL header file with firmware Gavin Shan
2014-05-14 4:12 ` [PATCH 6/8] powerpc: Extend syscall ppc_rtas() Gavin Shan
2014-05-19 12:55 ` Alexander Graf
2014-05-19 22:38 ` Benjamin Herrenschmidt
2014-05-14 4:12 ` [PATCH 7/8] powerpc/powernv: Implement ppc_call_opal() Gavin Shan
2014-05-19 12:59 ` Alexander Graf
2014-05-14 4:12 ` [PATCH 8/8] powerpc/powernv: Error injection infrastructure Gavin Shan
2014-05-19 13:04 ` Alexander Graf
2014-05-19 22:40 ` Benjamin Herrenschmidt
2014-05-15 6:34 ` [PATCH RFC v3 0/8] EEH Support for VFIO PCI device Mike Qiu
2014-05-15 7:43 ` Gavin Shan
2014-05-19 10:07 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537B282E.6040107@suse.de \
--to=agraf@suse$(echo .)de \
--cc=aik@ozlabs$(echo .)ru \
--cc=alex.williamson@redhat$(echo .)com \
--cc=gwshan@linux$(echo .)vnet.ibm.com \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=qiudayu@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox