From: Alexander Graf <agraf@suse•de>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
Michael Neuling <mikey@neuling•org>,
Paul Mackerras <paulus@samba•org>,
"kvm@vger•kernel.org" <kvm@vger•kernel.org>,
"kvm-ppc@vger•kernel.org" <kvm-ppc@vger•kernel.org>
Subject: Re: powerpc/pseries: Use new defines when calling h_set_mode
Date: Fri, 30 May 2014 09:44:35 +0200 [thread overview]
Message-ID: <538836E3.1060600@suse.de> (raw)
In-Reply-To: <1401400361.14938.16.camel@pasglop>
On 29.05.14 23:52, Benjamin Herrenschmidt wrote:
> On Thu, 2014-05-29 at 23:27 +0200, Alexander Graf wrote:
>> On 29.05.14 09:45, Michael Neuling wrote:
>>>>> +/* Values for 2nd argument to H_SET_MODE */
>>>>> +#define H_SET_MODE_RESOURCE_SET_CIABR 1
>>>>> +#define H_SET_MODE_RESOURCE_SET_DAWR 2
>>>>> +#define H_SET_MODE_RESOURCE_ADDR_TRANS_MODE 3
>>>>> +#define H_SET_MODE_RESOURCE_LE 4
>>>> Much better, but I think you want to make use of these in non-kvm code too,
>>>> no? At least the LE one is definitely already implemented as call :)
>>> Sure but that's a different patch.... below.
>> Ben, how would you like to handle these 2 patches? If you give me an ack
>> I can just put this patch into my kvm queue. Alternatively we could both
>> carry a patch that adds the H_SET_MODE header bits only and whoever hits
>> Linus' tree first wins ;).
> No biggie. Worst case it's a trivial conflict.
Well, the way the patches are split right now it won't be a conflict,
but a build failure on either side.
Alex
next prev parent reply other threads:[~2014-05-30 7:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1401106626-13130-1-git-send-email-paulus@samba.org>
[not found] ` <1401106626-13130-4-git-send-email-paulus@samba.org>
[not found] ` <5385E620.5090703@suse.de>
[not found] ` <1401342462.4116.4.camel@ale.ozlabs.ibm.com>
[not found] ` <1401344549.4116.8.camel@ale.ozlabs.ibm.com>
[not found] ` <BD1CF085-FEBC-4208-AD3F-C55DB002097F@suse.de>
2014-05-29 7:45 ` powerpc/pseries: Use new defines when calling h_set_mode Michael Neuling
2014-05-29 21:27 ` Alexander Graf
2014-05-29 21:52 ` Benjamin Herrenschmidt
2014-05-30 7:44 ` Alexander Graf [this message]
2014-05-30 8:56 ` Michael Ellerman
2014-05-30 9:10 ` Michael Neuling
2014-05-30 9:13 ` Alexander Graf
2014-05-30 9:44 ` Michael Neuling
2014-05-30 9:44 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538836E3.1060600@suse.de \
--to=agraf@suse$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mikey@neuling$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox