From: Guenter Roeck <linux@roeck-us•net>
To: David Rientjes <rientjes@google•com>
Cc: Vincent Guittot <vincent.guittot@linaro•org>,
Paul Mackerras <paulus@samba•org>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] powerpc: Fix build warning
Date: Mon, 16 Jun 2014 19:02:09 -0700 [thread overview]
Message-ID: <539FA1A1.6030502@roeck-us.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1406161824340.21018@chino.kir.corp.google.com>
On 06/16/2014 06:25 PM, David Rientjes wrote:
> On Fri, 13 Jun 2014, Guenter Roeck wrote:
>
>> If compiled with W=1, the following warning is seen in powerpc builds.
>>
>> arch/powerpc/kernel/smp.c:750:18: warning:
>> type qualifiers ignored on function return type
>> static const int powerpc_smt_flags(void)
>> ^
>>
>> This is caused by a function returning 'const int', which doesn't
>> make sense to gcc. Drop 'const' to fix the problem.
>>
>> Reported-by: Vincent Guittot <vincent.guittot@linaro•org>
>> Signed-off-by: Guenter Roeck <linux@roeck-us•net>
>
> Acked-by: David Rientjes <rientjes@google•com>
>
> Although it's strange you report this happening on line 750 in the
> changelog but the patch shows it differently.
>
In the latest kernel (v3.16-rc1) the function is at line 750.
It appears that I ran the build test on a later version than
the one I used to write the patch. Hope that is not a problem.
Guenter
next prev parent reply other threads:[~2014-06-17 2:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 16:38 [PATCH] powerpc: Fix build warning Guenter Roeck
2014-06-17 1:25 ` David Rientjes
2014-06-17 2:02 ` Guenter Roeck [this message]
2014-06-24 4:35 ` Benjamin Herrenschmidt
2014-06-24 5:05 ` Guenter Roeck
2014-06-24 5:34 ` Benjamin Herrenschmidt
2014-06-24 6:01 ` Guenter Roeck
2014-06-24 6:38 ` Benjamin Herrenschmidt
2014-06-25 7:53 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539FA1A1.6030502@roeck-us.net \
--to=linux@roeck-us$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=rientjes@google$(echo .)com \
--cc=vincent.guittot@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox