From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi•com>
To: Michael Ellerman <mpe@ellerman•id.au>
Cc: Jeremy Fitzhardinge <jeremy@goop•org>,
linux-ia64@vger•kernel.org, sparse@chrisli•org,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Paul Mackerras <paulus@samba•org>,
"H. Peter Anvin" <hpa@zytor•com>,
akataria@vmware•com, linux-tip-commits@vger•kernel.org,
anil.s.keshavamurthy@intel•com, Ingo Molnar <mingo@kernel•org>,
"Suzuki K. Poulose" <suzuki@in•ibm.com>,
Fenghua Yu <fenghua.yu@intel•com>, Arnd Bergmann <arnd@arndb•de>,
Rusty Russell <rusty@rustcorp•com.au>,
Chris Wright <chrisw@sous-sol•org>,
yrl.pp-manager.tt@hitachi•com,
Thomas Gleixner <tglx@linutronix•de>,
Tony Luck <tony.luck@intel•com>, Kevin Hao <haokexin@gmail•com>,
Linus Torvalds <torvalds@linux-foundation•org>,
rdunlap@infradead•org, Tony Luck <tony.luck@gmail•com>,
dl9pf@gmx•de, Andrew Morton <akpm@linux-foundation•org>,
linuxppc-dev@lists•ozlabs.org,
"David S. Miller" <davem@davemloft•net>
Subject: Re: Re: Re: Re: [PATCH v4] [BUGFIX] kprobes: Fix "Failed to find blacklist" error on ia64 and ppc64
Date: Wed, 02 Jul 2014 16:16:15 +0900 [thread overview]
Message-ID: <53B3B1BF.2040404@hitachi.com> (raw)
In-Reply-To: <1404284165.7254.2.camel@concordia>
(2014/07/02 15:56), Michael Ellerman wrote:
> On Wed, 2014-07-02 at 15:39 +0900, Masami Hiramatsu wrote:
>> (2014/07/02 13:41), Michael Ellerman wrote:
>>> On Tue, 2014-07-01 at 11:21 +0900, Masami Hiramatsu wrote:
>>>> (2014/06/30 20:36), Michael Ellerman wrote:
>>>>> On Mon, 2014-06-30 at 12:14 +0900, Masami Hiramatsu wrote:
>>>>>> Ping? :)
>>>>>
>>>>> Yeah sorry. I started looking at this and got dragged into another mess.
>>>>>
>>>>> You seem to have duplicated the functionality of arch_deref_entry_point(),
>>>>> which was also added for kprobes, and for the same reason - ie. because some
>>>>> arches have strange function pointers. Is there some reason you can't use it?
>>>>
>>>> Ah, right! Hmm, it seems some more work to update it. but basically, we can do.
>>>> BTW, is there any other users who need to access the actual function entry (for
>>>> kallsyms case)?
>>>
>>> Not that I'm aware of. We have had function descriptors on 64-bit powerpc for
>>> ever, so in theory by now we should have already found any cases where we need
>>> that sort of wrapper.
>>
>> OK, then I'll update this patch to use arch_deref_entry_point(), and add additional
>> patch which update to support PPC64 ABIv2.
>
> I've already done the latter:
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=2f0143c91d30823f6f6e7d94d7fa818f7ab18a18
Oh, thanks!
In that case, my 1/2 patch should be dropped.
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi•com
next prev parent reply other threads:[~2014-07-02 7:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 2:23 [PATCH v4] [BUGFIX] kprobes: Fix "Failed to find blacklist" error on ia64 and ppc64 Masami Hiramatsu
2014-06-30 3:14 ` Masami Hiramatsu
2014-06-30 11:36 ` Michael Ellerman
2014-07-01 2:21 ` Masami Hiramatsu
2014-07-02 4:41 ` Michael Ellerman
2014-07-02 6:39 ` Masami Hiramatsu
2014-07-02 6:56 ` Michael Ellerman
2014-07-02 7:16 ` Masami Hiramatsu [this message]
2014-07-02 7:00 ` [PATCH v5 1/2] kprobes/powerpc: Fix arch_deref_entry_point to support ABIv2 Masami Hiramatsu
2014-07-02 7:18 ` Masami Hiramatsu
2014-07-02 7:00 ` [PATCH v5 2/2] [BUGFIX] kprobes: Fix "Failed to find blacklist" error on ia64 and ppc64 Masami Hiramatsu
2014-07-08 12:07 ` Masami Hiramatsu
2014-07-14 17:17 ` Tony Luck
2014-07-15 2:11 ` Michael Ellerman
2014-07-15 2:24 ` Masami Hiramatsu
2014-07-15 3:16 ` Michael Ellerman
2014-07-15 3:19 ` Michael Ellerman
2014-07-15 7:16 ` Benjamin Herrenschmidt
2014-07-15 10:09 ` Masami Hiramatsu
2014-07-16 13:28 ` Ingo Molnar
2014-07-17 7:10 ` Masami Hiramatsu
2014-07-17 9:40 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B3B1BF.2040404@hitachi.com \
--to=masami.hiramatsu.pt@hitachi$(echo .)com \
--cc=akataria@vmware$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=anil.s.keshavamurthy@intel$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=chrisw@sous-sol$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dl9pf@gmx$(echo .)de \
--cc=fenghua.yu@intel$(echo .)com \
--cc=haokexin@gmail$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=jeremy@goop$(echo .)org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-tip-commits@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@kernel$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
--cc=rdunlap@infradead$(echo .)org \
--cc=rusty@rustcorp$(echo .)com.au \
--cc=sparse@chrisli$(echo .)org \
--cc=suzuki@in$(echo .)ibm.com \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@gmail$(echo .)com \
--cc=tony.luck@intel$(echo .)com \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=yrl.pp-manager.tt@hitachi$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox