From: Guenter Roeck <linux@roeck-us•net>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: "devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
lm-sensors@lm-sensors•org, sbhat@linux•vnet.ibm.com,
Neelesh Gupta <neelegup@linux•vnet.ibm.com>,
linuxppc-dev@lists•ozlabs.org, jdelvare@suse•de
Subject: Re: [PATCH v4] powerpc/powernv: hwmon driver for power, fan rpm, voltage and temperature
Date: Mon, 07 Jul 2014 05:59:31 -0700 [thread overview]
Message-ID: <53BA99B3.7050605@roeck-us.net> (raw)
In-Reply-To: <1404716172.16156.8.camel@pasglop>
On 07/06/2014 11:56 PM, Benjamin Herrenschmidt wrote:
> On Fri, 2014-07-04 at 19:25 -0700, Guenter Roeck wrote:
>>> +cooling-fan#8-data {
>>> + sensor-id = <0x7052107>;
>>> + phandle = <0x10000028>;
>>> + linux,phandle = <0x10000028>;
>>> + compatible = "ibm,opal-sensor-cooling-fan";
>>
>> phandle and linux-phandle are neither documented nor used. Either
>> document or drop.
>
> They are core device-tree stuff, as such they are used potentially
> anywhere and afaik can be / are generated by DTC but yes, this is
> not the place to document them.
>
Turns out they are documented elsewhere. See
Documentation/devicetree/booting-without-of.txt.
> Or rather, "phandle" is, "linux,phandle" is an older variant used
> for backward compatibility that our firmware still generates but
> definitely something we can strip from the doc.
>
Both are not mentioned in any other bindings, so my take is they should
not be mentioned here either.
Thanks,
Guenter
prev parent reply other threads:[~2014-07-07 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 11:02 [PATCH v4] powerpc/powernv: hwmon driver for power, fan rpm, voltage and temperature Neelesh Gupta
2014-07-05 2:25 ` Guenter Roeck
2014-07-07 6:56 ` Benjamin Herrenschmidt
2014-07-07 12:59 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BA99B3.7050605@roeck-us.net \
--to=linux@roeck-us$(echo .)net \
--cc=benh@kernel$(echo .)crashing.org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=jdelvare@suse$(echo .)de \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lm-sensors@lm-sensors$(echo .)org \
--cc=neelegup@linux$(echo .)vnet.ibm.com \
--cc=sbhat@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox