Subject: Re: [PATCH v4] powerpc/powernv: hwmon driver for power, fan rpm, voltage and temperature

From: Guenter Roeck <[email-masked]>
Date: Mon, 07 Jul 2014 05:59:31 -0700

On 07/06/2014 11:56 PM, Benjamin Herrenschmidt wrote:
> On Fri, 2014-07-04 at 19:25 -0700, Guenter Roeck wrote:
>>> +cooling-fan#8-data {
>>> +     sensor-id = <0x7052107>;
>>> +     phandle = <0x10000028>;
>>> +     linux,phandle = <0x10000028>;
>>> +     compatible = "ibm,opal-sensor-cooling-fan";
>>
>> phandle and linux-phandle are neither documented nor used. Either
>> document or drop.
>
> They are core device-tree stuff, as such they are used potentially
> anywhere and afaik can be / are generated by DTC but yes, this is
> not the place to document them.
>

Turns out they are documented elsewhere. See
Documentation/devicetree/booting-without-of.txt.

> Or rather, "phandle" is, "linux,phandle" is an older variant used
> for backward compatibility that our firmware still generates but
> definitely something we can strip from the doc.
>

Both are not mentioned in any other bindings, so my take is they should
not be mentioned here either.

Thanks,
Guenter