From: Chen Gang <gang.chen.5i5j@gmail•com>
To: Max Filippov <jcmvbkbc@gmail•com>
Cc: Linux/MIPS Mailing List <linux-mips@linux-mips•org>,
linux-s390@vger•kernel.org, Aurelien Jacquiot <a-jacquiot@ti•com>,
Catalin Marinas <catalin.marinas@arm•com>,
linux@lists•openrisc.net, Will Deacon <will.deacon@arm•com>,
David Howells <dhowells@redhat•com>,
Paul Mackerras <paulus@samba•org>,
"H. Peter Anvin" <hpa@zytor•com>,
sparclinux@vger•kernel.org, linux-hexagon@vger•kernel.org,
Guan Xuetao <gxt@mprc•pku.edu.cn>,
Jean Delvare <jdelvare@suse•de>,
egtvedt@samfundet•no, Jonas Bonn <jonas@southpole•se>,
Liqin Chen <liqin.linux@gmail•com>,
jesper.nilsson@axis•com, linux-am33-list@redhat•com,
Russell King <linux@arm•linux.org.uk>,
linux-c6x-dev@linux-c6x•org,
"David S. Miller" <davem@davemloft•net>,
"linux-xtensa@linux-xtensa•org" <linux-xtensa@linux-xtensa•org>,
takata@linux-m32r•org, x86@kernel•org, jejb@parisc-linux•org,
Ingo Molnar <mingo@redhat•com>,
Geert Uytterhoeven <geert@linux-m68k•org>,
Lennox Wu <lennox.wu@gmail•com>, Mark Salter <msalter@redhat•com>,
Matt Turner <mattst88@gmail•com>,
hskinnemoen@gmail•com, fenghua.yu@intel•com,
James Hogan <james.hogan@imgtec•com>,
Arnd Bergmann <arnd@arndb•de>,
realmz6@gmail•com, linux-kbuild <linux-kbuild@vger•kernel.org>,
heiko.carstens@de•ibm.com, jdike@addtoit•com,
linux-alpha@vger•kernel.org,
adi-buildroot-devel@lists•sourceforge.net,
Chris Metcalf <cmetcalf@tilera•com>,
starvik@axis•com, linux-m68k@lists•linux-m68k.org,
Ivan Kokshaysky <ink@jurassic•park.msu.ru>,
user-mode-linux-user@lists•sourceforge.net,
Thomas Gleixner <tglx@linutronix•de>,
linux-metag@vger•kernel.org,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
Richard Henderson <rth@twiddle•net>,
Chris Zankel <chris@zankel•net>, Michal Simek <monstr@monstr•eu>,
tony.luck@intel•com, linux-ia64@vger•kernel.org,
linux-parisc@vger•kernel.org, linux-cris-kernel@axis•com,
"vgupta@synopsys•com" <vgupta@synopsys•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
Ralf Baechle <ralf@linux-mips•org>,
rkuo@codeaurora•org, user-mode-linux-devel@lists•sourceforge.net,
Richard Weinberger <richard@nod•at>,
Martin Schwidefsky <schwidefsky@de•ibm.com>,
linux390@de•ibm.com, Andrew Morton <akpm@linux-foundation•org>,
yasutake.koichi@jp•panasonic.com, linuxppc-dev@lists•ozlabs.org,
deller@gmx•de
Subject: Re: [PATCH v3] arch: Kconfig: Let all architectures set endian explicitly
Date: Fri, 15 Aug 2014 10:06:56 +0800 [thread overview]
Message-ID: <53ED6B40.8000409@gmail.com> (raw)
In-Reply-To: <CAMo8Bf+=EgXc0hq14y9Kdykaw_7E52kRAENU1P0fAK4tTx=JpA@mail.gmail.com>
On 8/15/14 9:52, Max Filippov wrote:
> On Fri, Aug 15, 2014 at 5:47 AM, Max Filippov <jcmvbkbc@gmail•com> wrote:
>> Hi Chen,
>>
>> On Thu, Aug 14, 2014 at 8:54 PM, Chen Gang <gang.chen.5i5j@gmail•com> wrote:
>>> Normal architectures:
>>>
>>> - Big endian: avr32, frv, m68k, openrisc, parisc, s390, sparc
>>>
>>> - Little endian: alpha, blackfin, cris, hexagon, ia64, metag, mn10300,
>>> score, unicore32, x86
>>>
>>> - Choose in config time: arc, arm, arm64, c6x, m32r, mips, powerpc, sh
>>>
>>> Special architectures:
>>>
>>> - Deside by compiler: microblaze, tile, xtensa.
>>>
>>> - Deside by building host: um
>>>
>>> - Next, need improve Kbuild to probe endian to deside whether need mark
>>> __BUILDING_TIME_BIG_ENDIAN__ before real config.
Please check this comments, thanks.
>>
>> [...]
>>
>>> diff --git a/arch/xtensa/Kconfig b/arch/xtensa/Kconfig
>>> index 3a617af..a3e8f7e 100644
>>> --- a/arch/xtensa/Kconfig
>>> +++ b/arch/xtensa/Kconfig
>>> @@ -22,6 +22,8 @@ config XTENSA
>>> select HAVE_IRQ_TIME_ACCOUNTING
>>> select HAVE_PERF_EVENTS
>>> select COMMON_CLK
>>> + select CPU_BIG_ENDIAN if __BUILDING_TIME_BIG_ENDIAN__
>>> + select CPU_LITTLE_ENDIAN if !CPU_BIG_ENDIAN
>>> help
>>> Xtensa processors are 32-bit RISC machines designed by Tensilica
>>> primarily for embedded systems. These processors are both
>>
>> I've tested this part and it doesn't select neither CPU_BIG_ENDIAN,
>> nor CPU_LITTLE_ENDIAN. And looking into the Kconfig/Kbuild I cound't
>
> Correction: it always selects CPU_LITTLE_ENDIAN, regardless of the
> compiler endianness.
>
Yeah, at present, it always select CPU_LITTLE_ENDIAN, next, Kbuild need
be improved for it, just the comments said.
If this patch can be pass checking, I shall improve the Kbuild for it,
also will modify some individual drivers to use CPU_*_ENDIAN.
I guess, we need Cc to kbuild for getting more ideas, suggestions, or
completions.
THanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
prev parent reply other threads:[~2014-08-15 2:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 16:54 [PATCH v3] arch: Kconfig: Let all architectures set endian explicitly Chen Gang
2014-08-14 18:04 ` Ralf Baechle
2014-08-14 22:14 ` Chen Gang
2014-08-15 9:01 ` Chen Gang
2014-08-24 8:38 ` Chen Gang
2014-08-25 12:26 ` Chen Gang
2014-08-14 18:21 ` Vineet Gupta
2014-08-14 18:27 ` Lennox Wu
2014-08-14 22:22 ` Chen Gang
2014-08-14 23:12 ` Vineet Gupta
2014-08-15 1:29 ` Chen Gang
2014-08-15 1:47 ` Max Filippov
2014-08-15 1:52 ` Max Filippov
2014-08-15 2:06 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ED6B40.8000409@gmail.com \
--to=gang.chen.5i5j@gmail$(echo .)com \
--cc=a-jacquiot@ti$(echo .)com \
--cc=adi-buildroot-devel@lists$(echo .)sourceforge.net \
--cc=akpm@linux-foundation$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chris@zankel$(echo .)net \
--cc=cmetcalf@tilera$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=dhowells@redhat$(echo .)com \
--cc=egtvedt@samfundet$(echo .)no \
--cc=fenghua.yu@intel$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=gxt@mprc$(echo .)pku.edu.cn \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=hskinnemoen@gmail$(echo .)com \
--cc=ink@jurassic$(echo .)park.msu.ru \
--cc=james.hogan@imgtec$(echo .)com \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=jdelvare@suse$(echo .)de \
--cc=jdike@addtoit$(echo .)com \
--cc=jejb@parisc-linux$(echo .)org \
--cc=jesper.nilsson@axis$(echo .)com \
--cc=jonas@southpole$(echo .)se \
--cc=lennox.wu@gmail$(echo .)com \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-am33-list@redhat$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-c6x-dev@linux-c6x$(echo .)org \
--cc=linux-cris-kernel@axis$(echo .)com \
--cc=linux-hexagon@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kbuild@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@lists$(echo .)linux-m68k.org \
--cc=linux-metag@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-xtensa@linux-xtensa$(echo .)org \
--cc=linux390@de$(echo .)ibm.com \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=linux@lists$(echo .)openrisc.net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=liqin.linux@gmail$(echo .)com \
--cc=mattst88@gmail$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=monstr@monstr$(echo .)eu \
--cc=msalter@redhat$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=ralf@linux-mips$(echo .)org \
--cc=realmz6@gmail$(echo .)com \
--cc=richard@nod$(echo .)at \
--cc=rkuo@codeaurora$(echo .)org \
--cc=rth@twiddle$(echo .)net \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=starvik@axis$(echo .)com \
--cc=takata@linux-m32r$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=user-mode-linux-devel@lists$(echo .)sourceforge.net \
--cc=user-mode-linux-user@lists$(echo .)sourceforge.net \
--cc=vgupta@synopsys$(echo .)com \
--cc=will.deacon@arm$(echo .)com \
--cc=x86@kernel$(echo .)org \
--cc=yasutake.koichi@jp$(echo .)panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox