From: Tomeu Vizoso <tomeu.vizoso@collabora•com>
To: Ulf Hansson <ulf.hansson@linaro•org>
Cc: "Andrew Lunn" <andrew@lunn•ch>,
alsa-devel@alsa-project•org,
"Prashant Gaikwad" <pgaikwad@nvidia•com>,
"Tony Lindgren" <tony@atomide•com>,
"Tomasz Figa" <t.figa@samsung•com>,
"Liam Girdwood" <lgirdwood@gmail•com>,
"Thierry Reding" <thierry.reding@gmail•com>,
"Paul Mackerras" <paulus@samba•org>,
"Sylwester Nawrocki" <s.nawrocki@samsung•com>,
"Daniel Walker" <dwalker@fifo99•com>,
linux-arch@vger•kernel.org,
"Boris Brezillon" <boris.brezillon@free-electrons•com>,
linux-samsung-soc <linux-samsung-soc@vger•kernel.org>,
"Kukjin Kim" <kgene.kim@samsung•com>,
"Mike Turquette" <mturquette@linaro•org>,
"Emilio López" <emilio@elopez•com.ar>,
"Takashi Iwai" <tiwai@suse•de>,
"Michal Simek" <michal.simek@xilinx•com>,
"Kyungmin Park" <kyungmin.park@samsung•com>,
"Kevin Hilman" <khilman@deeprootsystems•com>,
linux-omap <linux-omap@vger•kernel.org>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
patches@opensource•wolfsonmicro.com,
"Viresh Kumar" <viresh.linux@gmail•com>,
"David Brown" <davidb@codeaurora•org>,
"Anatolij Gustschin" <agust@denx•de>,
"Dinh Nguyen" <dinguyen@altera•com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail•com>,
"Jason Cooper" <jason@lakedaemon•net>,
"Arnd Bergmann" <arnd@arndb•de>,
"Stephen Warren" <swarren@wwwdotorg•org>,
"linux-arm-msm@vger•kernel.org" <linux-arm-msm@vger•kernel.org>,
spear-devel@list•st.com, "Barry Song" <baohua@kernel•org>,
"Mark Brown" <broonie@kernel•org>,
linux-rpi-kernel@lists•infradead.org,
"Ben Dooks" <ben-linux@fluff•org>,
"linux-tegra@vger•kernel.org" <linux-tegra@vger•kernel.org>,
"Russell King" <linux@arm•linux.org.uk>,
"Jaroslav Kysela" <perex@perex•cz>,
"Sascha Hauer" <kernel@pengutronix•de>,
"Shawn Guo" <shawn.guo@freescale•com>,
"Paul Walmsley" <paul@pwsan•com>,
"Peter De Schrijver" <pdeschrijver@nvidia•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
rabin@rab•in, "Bryan Huntsman" <bryanh@codeaurora•org>,
"Santosh Shilimkar" <santosh.shilimkar@ti•com>,
"Benoît Cousson" <bcousson@baylibre•com>,
"Maxime Ripard" <maxime.ripard@free-electrons•com>,
linux-media@vger•kernel.org,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
"Mauro Carvalho Chehab" <m.chehab@samsung•com>
Subject: Re: [PATCH v8 3/7] clk: Move all drivers to use internal API
Date: Wed, 03 Sep 2014 14:59:38 +0200 [thread overview]
Message-ID: <540710BA.60108@collabora.com> (raw)
In-Reply-To: <CAPDyKFq2vzUT+NSkC8ZTau=sbFW_frpQ+paLM_EsYLyp_5ivag@mail.gmail.com>
On 09/02/2014 09:13 AM, Ulf Hansson wrote:
> On 1 September 2014 17:32, Tomeu Vizoso <tomeu.vizoso@collabora•com> wrote:
>> In preparation to change the public API to return a per-user clk structure,
>> remove any usage of this public API from the clock implementations.
>>
>> The reason for having this in a separate commit from the one that introduces
>> the implementation of the new functions is to separate the changes generated
>> with Coccinelle from the rest, and keep the patches' size reasonable.
>>
>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora•com>
>> Tested-by: Boris Brezillon <boris.brezillon@free-electrons•com>
>> Tested-by: Heiko Stuebner <heiko@sntech•de>
>> Acked-by: Boris Brezillon <boris.brezillon@free-electrons•com>
>
> Hi Tomeu,
>
> Huh, what a patch. :-) Great work you are doing here!
Thanks!
> By just looking at the ux500 changes, I realize that you now have
> removed the dependency to "struct clk", thus we shouldn't include the
> header file linux/clk.h in any file located in driver/clk/ux500/*,
> right!?
>
> I suppose this comment may also applicable for others than the ux500
> clk driver, but haven't checked.
You are right. I have gone ahead and removed the include from all files
that are fed to the coccinelle script. Everything builds fine in all
configurations I have tested, so I will be adding it to v9.
Thanks for the idea,
Tomeu
> Kind regards
> Uffe
>
prev parent reply other threads:[~2014-09-03 12:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1409585377-26091-1-git-send-email-tomeu.vizoso@collabora.com>
2014-09-01 15:32 ` [PATCH v8 3/7] clk: Move all drivers to use internal API Tomeu Vizoso
2014-09-02 7:13 ` Ulf Hansson
2014-09-03 12:59 ` Tomeu Vizoso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540710BA.60108@collabora.com \
--to=tomeu.vizoso@collabora$(echo .)com \
--cc=agust@denx$(echo .)de \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=arnd@arndb$(echo .)de \
--cc=baohua@kernel$(echo .)org \
--cc=bcousson@baylibre$(echo .)com \
--cc=ben-linux@fluff$(echo .)org \
--cc=boris.brezillon@free-electrons$(echo .)com \
--cc=broonie@kernel$(echo .)org \
--cc=bryanh@codeaurora$(echo .)org \
--cc=davidb@codeaurora$(echo .)org \
--cc=dinguyen@altera$(echo .)com \
--cc=dwalker@fifo99$(echo .)com \
--cc=emilio@elopez$(echo .)com.ar \
--cc=jason@lakedaemon$(echo .)net \
--cc=kernel@pengutronix$(echo .)de \
--cc=kgene.kim@samsung$(echo .)com \
--cc=khilman@deeprootsystems$(echo .)com \
--cc=kyungmin.park@samsung$(echo .)com \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-rpi-kernel@lists$(echo .)infradead.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=m.chehab@samsung$(echo .)com \
--cc=maxime.ripard@free-electrons$(echo .)com \
--cc=michal.simek@xilinx$(echo .)com \
--cc=mturquette@linaro$(echo .)org \
--cc=patches@opensource$(echo .)wolfsonmicro.com \
--cc=paul@pwsan$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=pdeschrijver@nvidia$(echo .)com \
--cc=perex@perex$(echo .)cz \
--cc=pgaikwad@nvidia$(echo .)com \
--cc=rabin@rab$(echo .)in \
--cc=s.nawrocki@samsung$(echo .)com \
--cc=santosh.shilimkar@ti$(echo .)com \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=shawn.guo@freescale$(echo .)com \
--cc=spear-devel@list$(echo .)st.com \
--cc=swarren@wwwdotorg$(echo .)org \
--cc=t.figa@samsung$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=tiwai@suse$(echo .)de \
--cc=tony@atomide$(echo .)com \
--cc=ulf.hansson@linaro$(echo .)org \
--cc=viresh.linux@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox