From: Emil Medve <Emilian.Medve@Freescale•com>
To: Anton Blanchard <anton@samba•org>, <benh@kernel•crashing.org>,
<paulus@samba•org>, <mpe@ellerman•id.au>
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 3/5] powerpc: Remove superfluous bootmem includes
Date: Wed, 17 Sep 2014 03:49:37 -0500 [thread overview]
Message-ID: <54194B21.6050105@Freescale.com> (raw)
In-Reply-To: <1410933504-28564-3-git-send-email-anton@samba.org>
Hello Anton,
On 09/17/2014 12:58 AM, Anton Blanchard wrote:
> Lots of places included bootmem.h even when not using bootmem.
>
> Signed-off-by: Anton Blanchard <anton@samba•org>
> ---
> arch/powerpc/kernel/crash_dump.c | 1 -
> arch/powerpc/kernel/irq.c | 1 -
> arch/powerpc/kernel/pci_64.c | 1 -
> arch/powerpc/kernel/rtas_pci.c | 1 -
> arch/powerpc/kernel/setup_32.c | 1 -
> arch/powerpc/kernel/vdso.c | 1 -
> arch/powerpc/kvm/book3s_hv_builtin.c | 1 -
> arch/powerpc/mm/init_32.c | 1 -
> arch/powerpc/mm/init_64.c | 1 -
> arch/powerpc/mm/pgtable_64.c | 1 -
> arch/powerpc/platforms/cell/celleb_scc_epci.c | 1 -
> arch/powerpc/platforms/cell/celleb_scc_pciex.c | 1 -
> arch/powerpc/platforms/maple/pci.c | 1 -
> arch/powerpc/platforms/powermac/pci.c | 1 -
> arch/powerpc/platforms/powernv/eeh-ioda.c | 1 -
> arch/powerpc/platforms/powernv/pci.c | 1 -
> arch/powerpc/sysdev/fsl_msi.c | 1 -
> arch/powerpc/sysdev/ipic.c | 1 -
> arch/powerpc/sysdev/mpic.c | 1 -
> arch/powerpc/sysdev/mpic_pasemi_msi.c | 1 -
> arch/powerpc/sysdev/mpic_u3msi.c | 1 -
> arch/powerpc/sysdev/ppc4xx_msi.c | 1 -
> arch/powerpc/sysdev/ppc4xx_pci.c | 1 -
> arch/powerpc/sysdev/qe_lib/qe.c | 1 -
> arch/powerpc/sysdev/qe_lib/qe_ic.c | 1 -
> arch/powerpc/sysdev/uic.c | 1 -
> 26 files changed, 26 deletions(-)
> ...
> diff --git a/arch/powerpc/mm/pgtable_64.c b/arch/powerpc/mm/pgtable_64.c
> index aa91737..feed47c 100644
> --- a/arch/powerpc/mm/pgtable_64.c
> +++ b/arch/powerpc/mm/pgtable_64.c
> @@ -33,7 +33,6 @@
> #include <linux/swap.h>
> #include <linux/stddef.h>
> #include <linux/vmalloc.h>
> -#include <linux/bootmem.h>
> #include <linux/memblock.h>
> #include <linux/slab.h>
While building corenet64_smp I get this:
> ../arch/powerpc/mm/pgtable_64.c: In function 'early_alloc_pgtable':
> ../arch/powerpc/mm/pgtable_64.c:77:95: error: 'MAX_DMA_ADDRESS' undeclared (first use in this function)
> ../arch/powerpc/mm/pgtable_64.c:77:95: note: each undeclared identifier is reported only once for each function it appears in
Adding '#include <asm/dma.h>' seems to fix it
Other than that, for the entire set:
Tested-by: Emil Medve <Emilian.Medve@Freescale•com>
Cheers,
next prev parent reply other threads:[~2014-09-17 9:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 5:58 [PATCH 1/5] powerpc: Remove bootmem allocator Anton Blanchard
2014-09-17 5:58 ` [PATCH 2/5] powerpc: Remove some old bootmem related comments Anton Blanchard
2014-09-17 5:58 ` [PATCH 3/5] powerpc: Remove superfluous bootmem includes Anton Blanchard
2014-09-17 8:49 ` Emil Medve [this message]
2014-09-17 12:08 ` Anton Blanchard
2014-09-17 5:58 ` [PATCH 4/5] powerpc: Move sparse_init() into initmem_init Anton Blanchard
2014-09-17 5:58 ` [PATCH 5/5] powerpc: make __ffs return unsigned long Anton Blanchard
-- strict thread matches above, loose matches on Subject: below --
2014-09-17 12:15 [PATCH 1/5] powerpc: Remove bootmem allocator Anton Blanchard
2014-09-17 12:15 ` [PATCH 3/5] powerpc: Remove superfluous bootmem includes Anton Blanchard
2014-08-05 6:32 [PATCH 1/5] powerpc: Remove bootmem allocator Anton Blanchard
2014-08-05 6:34 ` [PATCH 3/5] powerpc: Remove superfluous bootmem includes Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54194B21.6050105@Freescale.com \
--to=emilian.medve@freescale$(echo .)com \
--cc=anton@samba$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox