Subject: Re: [PATCH v4 04/11] drivers: base: support cpu cache information interface to userspace via sysfs

From: Sudeep Holla <[email-masked]>
Date: Mon, 22 Sep 2014 09:55:18 +0100

Hi Stephen,

On 19/09/14 23:24, Stephen Boyd wrote:
> On 09/03/14 10:00, Sudeep Holla wrote:
>> From: Sudeep Holla <[email-masked]>
>>
>> This patch adds initial support for providing processor cache informatio=
n
>> to userspace through sysfs interface. This is based on already existing
>> implementations(x86, ia64, s390 and powerpc) and hence the interface is
>> intended to be fully compatible.
>>
>> The main purpose of this generic support is to avoid further code
>> duplication to support new architectures and also to unify all the exist=
ing
>> different implementations.
>>
>> This implementation maintains the hierarchy of cache objects which refle=
cts
>> the system's cache topology. Cache devices are instantiated as needed as
>> CPUs come online. The cache information is replicated per-cpu even if th=
ey are
>> shared. A per-cpu array of cache information maintained is used mainly f=
or
>> sysfs-related book keeping.
>>
>> It also implements the shared_cpu_map attribute, which is essential for
>> enabling both kernel and user-space to discover the system's overall cac=
he
>> topology.
>>
>> This patch also add the missing ABI documentation for the cacheinfo sysf=
s
>> interface already, which is well defined and widely used.
>>
>> Signed-off-by: Sudeep Holla <[email-masked]>
>> Cc: Greg Kroah-Hartman <[email-masked]>
>> Cc: Stephen Boyd <[email-masked]>
>> Cc: [email-masked]
>> Cc: [email-masked]
>> Cc: [email-masked]
>> Cc: [email-masked]
>> Cc: [email-masked]
>> Cc: [email-masked]
>> Cc: [email-masked]
>>
>
> Reviewed-by: Stephen Boyd <[email-masked]>
> Tested-by: Stephen Boyd <[email-masked]>
>

Thanks for all the reviews and testings of the series.

Regards,
Sudeep