From: James Hogan <james.hogan@imgtec•com>
To: Guenter Roeck <linux@roeck-us•net>, <linux-kernel@vger•kernel.org>
Cc: linux-mips@linux-mips•org, linux-m68k@vger•kernel.org,
linux-ia64@vger•kernel.org, linux-sh@vger•kernel.org,
linux@openrisc•net, sparclinux@vger•kernel.org,
linux-s390@vger•kernel.org, linux-am33-list@redhat•com,
linux-c6x-dev@linux-c6x•org, linux-hexagon@vger•kernel.org,
x86@kernel•org, xen-devel@lists•xenproject.org,
linux-xtensa@linux-xtensa•org,
user-mode-linux-devel@lists•sourceforge.net,
linux-pm@vger•kernel.org,
adi-buildroot-devel@lists•sourceforge.net,
user-mode-linux-user@lists•sourceforge.net,
linux-metag@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-parisc@vger•kernel.org, linux-cris-kernel@axis•com,
linux-alpha@vger•kernel.org, linux390@de•ibm.com,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v2 08/47] kernel: Move pm_power_off to common code
Date: Fri, 24 Oct 2014 10:47:03 +0100 [thread overview]
Message-ID: <544A2017.7020804@imgtec.com> (raw)
In-Reply-To: <1413864783-3271-9-git-send-email-linux@roeck-us.net>
Hi Guenter,
On 21/10/14 05:12, Guenter Roeck wrote:
> pm_power_off is defined for all architectures. Move it to common code.
>
> Have all architectures call do_kernel_power_off instead of pm_power_off.
> Some architectures point pm_power_off to machine_power_off. For those,
> call do_kernel_power_off from machine_power_off instead.
>
> Acked-by: David Vrabel <david.vrabel@citrix•com>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k•org>
> Acked-by: Hirokazu Takata <takata@linux-m32r•org>
> Acked-by: Jesper Nilsson <jesper.nilsson@axis•com>
> Acked-by: Max Filippov <jcmvbkbc@gmail•com>
> Acked-by: Rafael J. Wysocki <rjw@rjwysocki•net>
> Acked-by: Richard Weinberger <richard@nod•at>
> Acked-by: Xuetao Guan <gxt@mprc•pku.edu.cn>
For metag:
Acked-by: James Hogan <james.hogan@imgtec•com>
Thanks
James
> diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c
> index 483dff9..8d95773 100644
> --- a/arch/metag/kernel/process.c
> +++ b/arch/metag/kernel/process.c
> @@ -67,9 +67,6 @@ void arch_cpu_idle_dead(void)
> }
> #endif
>
> -void (*pm_power_off)(void);
> -EXPORT_SYMBOL(pm_power_off);
> -
> void (*soc_restart)(char *cmd);
> void (*soc_halt)(void);
>
> @@ -90,8 +87,7 @@ void machine_halt(void)
>
> void machine_power_off(void)
> {
> - if (pm_power_off)
> - pm_power_off();
> + do_kernel_power_off();
> smp_send_stop();
> hard_processor_halt(HALT_OK);
> }
next prev parent reply other threads:[~2014-10-24 10:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1413864783-3271-1-git-send-email-linux@roeck-us.net>
2014-10-21 4:12 ` [PATCH v2 08/47] kernel: Move pm_power_off to common code Guenter Roeck
2014-10-22 15:31 ` Ralf Baechle
2014-10-22 15:43 ` Guenter Roeck
2014-10-24 9:47 ` James Hogan [this message]
2014-10-24 15:53 ` Guenter Roeck
2014-10-24 10:02 ` Lennox Wu
2014-10-24 10:03 ` Lennox Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544A2017.7020804@imgtec.com \
--to=james.hogan@imgtec$(echo .)com \
--cc=adi-buildroot-devel@lists$(echo .)sourceforge.net \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-am33-list@redhat$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-c6x-dev@linux-c6x$(echo .)org \
--cc=linux-cris-kernel@axis$(echo .)com \
--cc=linux-hexagon@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@vger$(echo .)kernel.org \
--cc=linux-metag@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-xtensa@linux-xtensa$(echo .)org \
--cc=linux390@de$(echo .)ibm.com \
--cc=linux@openrisc$(echo .)net \
--cc=linux@roeck-us$(echo .)net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=user-mode-linux-devel@lists$(echo .)sourceforge.net \
--cc=user-mode-linux-user@lists$(echo .)sourceforge.net \
--cc=x86@kernel$(echo .)org \
--cc=xen-devel@lists$(echo .)xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox