From: Corey Minyard <minyard@acm•org>
To: Jeremy Kerr <jk@ozlabs•org>,
openipmi-developer@lists•sourceforge.net,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 0/2] Add IPMI support for powernv powerpc machines
Date: Tue, 11 Nov 2014 15:07:24 -0600 [thread overview]
Message-ID: <54627A8C.20400@acm.org> (raw)
In-Reply-To: <5460307C.9060502@ozlabs.org>
On 11/09/2014 09:26 PM, Jeremy Kerr wrote:
> Hi Corey,
>
> Thanks for the review.
>
>>> IPMI folks: the IPMI driver could do with a little review, as it's
>>> not a conventional BT/KCS/SMI SI, in that the low-level send/recv
>>> interface will handle the entire message at once.
>> Handling the entire message at once should be fine, as that's what
>> this driver level is designed to do for the message handler. That
>> part all looks correct. The code itself looks good, but I have a
>> couple of high-level comments.
>>
>> The driver at this level can receive more than one message to handle
>> at a time, so it needs some sort of queue. This is to allow multiple
>> users and to allow the message handler to send its own commands while
>> other commands are going on. You might argue that the queuing should
>> be done in ipmi_msghandler, and you would probably be right.
> Ah, that's what I'd been assuming was being done - I missed the
> xmit_list in the si_intf code. It'd be great if this could be in the
> generic msghandler code, otherwise I'd just be duplicating the si_intf
> logic.
>
>> I'll look at doing that. If that is the case, then your NULL check
>> for current message should probably be a BUG_ON().
> OK, I'll update this when the msghandler bit is implemented.
I've finally finished that, you can get it at:
git://git.code.sf.net/p/openipmi/linux-ipmi
using the for-next branch. This is what goes into linux-next.
>> Do you need to handle any BMC flags? Particularly incoming events?
> Not at this stage - we may in future though.
Ok. That will complicate things a bit when they are added, but not very
much.
Thanks,
-corey
next prev parent reply other threads:[~2014-11-11 21:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 3:38 [PATCH 0/2] Add IPMI support for powernv powerpc machines Jeremy Kerr
2014-11-06 3:38 ` [PATCH 1/2] powerpc/powernv: Add OPAL IPMI interface Jeremy Kerr
2014-11-06 3:38 ` [PATCH 2/2] drivers/char/ipmi: Add powernv IPMI driver Jeremy Kerr
2014-11-06 14:15 ` [PATCH 0/2] Add IPMI support for powernv powerpc machines Corey Minyard
2014-11-10 3:26 ` Jeremy Kerr
2014-11-10 5:41 ` Benjamin Herrenschmidt
2014-11-10 6:01 ` Alistair Popple
2014-11-10 6:57 ` Benjamin Herrenschmidt
2014-11-10 6:41 ` Jeremy Kerr
2014-11-11 21:07 ` Corey Minyard [this message]
2014-11-12 6:10 ` Michael Ellerman
2014-11-12 7:37 ` Jeremy Kerr
2014-11-12 7:41 ` [PATCH v2] drivers/char/ipmi: Add powernv IPMI driver Jeremy Kerr
2014-11-14 1:42 ` Corey Minyard
2014-11-14 2:00 ` Jeremy Kerr
2014-11-14 2:04 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54627A8C.20400@acm.org \
--to=minyard@acm$(echo .)org \
--cc=jk@ozlabs$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=openipmi-developer@lists$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox