From: Valentin Longchamp <valentin.longchamp@keymile•com>
To: Wolfram Sang <wsa@the-dreams•de>
Cc: Linux device trees <devicetree@vger•kernel.org>,
"Boschung, Rainer" <Rainer.Boschung@keymile•com>,
"Brunck, Holger" <Holger.Brunck@keymile•com>,
Linux I2C <linux-i2c@vger•kernel.org>,
Scott Wood <scottwood@freescale•com>,
Linux PowerPC Kernel <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler
Date: Fri, 14 Nov 2014 08:43:01 +0100 [thread overview]
Message-ID: <5465B285.7070005@keymile.com> (raw)
In-Reply-To: <20141113003418.GE2062@katana>
On 11/13/2014 01:34 AM, Wolfram Sang wrote:
>
>> If we wanted to be on the safe side and strict (since we are not sure that the
>> hardware is 100% compatible), we maybe should add a fsl,qoriq-i2c compatible to
>> the driver that does the same as mpc8543-i2c.
>
> Or you leave the driver as is and use both compatibles:
>
> compatible = "fsl,qoriq-i2c", "fsl,mpc8543-i2c", "fsl-i2c";
>
> ?
>
I like Scott's proposition to add the prescaler in the device tree more. From
the hardware description point of view, it makes more sense: the devices are all
just fsl-i2c, with a different prescaler. I just quote it below as a reminder.
>
> If we're going to change the device tree I'd rather just add a property
> to say what the prescaler is.
We would however, leave the boards' device trees that use things like
"fsl,mpc8543-i2c" as is and introduce the prescaler for the others requiring it.
Now the drawback is that the driver would require a change, to parse this
prescaler new prescaler property. Would this be OK from your point of view
Wolfram ? If yes, I will send the patches for it.
Valentin
next prev parent reply other threads:[~2014-11-14 7:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 9:27 [PATCH] i2c-qoriq: modified compatibility for correct prescaler Valentin Longchamp
2014-10-28 23:08 ` Scott Wood
2014-10-29 8:59 ` Valentin Longchamp
2014-11-06 21:58 ` Scott Wood
2014-11-13 0:34 ` Wolfram Sang
2014-11-14 7:43 ` Valentin Longchamp [this message]
2014-11-14 8:28 ` Wolfram Sang
2014-11-18 1:28 ` Scott Wood
2014-11-25 18:13 ` Wolfram Sang
2014-11-26 1:41 ` Scott Wood
2014-11-30 4:30 ` Danielle Costantino
2014-12-01 17:23 ` Wolfram Sang
2014-12-11 13:44 ` Valentin Longchamp
2014-12-23 13:23 ` Valentin Longchamp
2014-12-23 13:49 ` Wolfram Sang
2014-12-27 2:43 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5465B285.7070005@keymile.com \
--to=valentin.longchamp@keymile$(echo .)com \
--cc=Holger.Brunck@keymile$(echo .)com \
--cc=Rainer.Boschung@keymile$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=scottwood@freescale$(echo .)com \
--cc=wsa@the-dreams$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox