public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed

From: Emil Medve <Emilian.Medve@Freescale•com>
To: Arnd Bergmann <arnd@arndb•de>
Cc: devicetree@vger•kernel.org,
	Poonam Aggrwal <poonam.aggrwal@Freescale•com>,
	Geoff Thorpe <Geoff.Thorpe@Freescale•com>,
	linuxppc-dev@ozlabs•org, Scott Wood <scottwood@Freescale•com>,
	Chunhe Lan <Chunhe.Lan@Freescale•com>
Subject: Re: [PATCH v3 3/4] powerpc/mpc85xx: Add FSL QorIQ DPAA BMan support to device tree(s)
Date: Wed, 3 Dec 2014 14:19:23 -0600	[thread overview]
Message-ID: <547F704B.5070400@Freescale.com> (raw)
In-Reply-To: <7923839.hEiWgLtlCl@wuerfel>

Hello Arnd,


Thanks for taking the time to review this

On 12/03/2014 01:42 PM, Arnd Bergmann wrote:
> On Wednesday 03 December 2014 01:53:39 Emil Medve wrote:
>> On 12/02/2014 06:32 PM, Scott Wood wrote:
>>> On Mon, 2014-12-01 at 04:02 -0600, Emil Medve wrote:
>>>> diff --git a/arch/powerpc/boot/dts/t4240rdb.dts b/arch/powerpc/boot/dts/t4240rdb.dts
>>>> index 53761d4..431bf4e 100644
>>>> --- a/arch/powerpc/boot/dts/t4240rdb.dts
>>>> +++ b/arch/powerpc/boot/dts/t4240rdb.dts
>>>> @@ -69,10 +69,27 @@
>>>>              device_type = "memory";
>>>>      };
>>>>  
>>>> +    reserved-memory {
>>>> +            #address-cells = <2>;
>>>> +            #size-cells = <2>;
>>>> +            ranges;
>>>> +
>>>> +            bman_fbpr: bman-fbpr {
>>>> +                    compatible = "fsl,bman-fbpr";
>>>> +                    alloc-ranges = <0 0 0xffff 0xffffffff>;
>>>> +                    size = <0 0x1000000>;
>>>> +                    alignment = <0 0x1000000>;
>>>> +            };
>>>> +    };
>>>
>>> Can't this be done at the SoC level rather than board level?
>>
>> The size of the memory is not SoC specific. Among other things is
>> determined by the number of MACs that are pinned-out on the board
> 
> Is this really a hardware property then, or some setting?

I'm unsure how to answer this. It is my opinion it's a hardware property
and that we're not stretching the intent of the reserved-memory binding

> Also, if you use the name 'ranges', I would assume that the second
> set of two cells is a length and should be <0 0 0x10000 0>.

Uh... Right. I'll fix it

> Finally, you add a label here, so anything that is not board
> specific could just stay in the per-soc file, with the board
> specific properties added at teh board level.

I will do that


Cheers,

next prev parent reply	other threads:[~2014-12-03 20:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01 10:02 [PATCH v3 0/4] powerpc/mpc85xx: Add FSL QorIQ DPAA B/QMan support to device tree(s) Emil Medve
2014-12-01 10:02 ` [PATCH v3 1/4] powerpc/mpc85xx: Create dts components for the FSL QorIQ DPAA BMan Emil Medve
2014-12-03  0:28   ` Scott Wood
2014-12-01 10:02 ` [PATCH v3 2/4] powerpc/mpc85xx: Create dts components for the FSL QorIQ DPAA QMan Emil Medve
2014-12-01 10:02 ` [PATCH v3 3/4] powerpc/mpc85xx: Add FSL QorIQ DPAA BMan support to device tree(s) Emil Medve
2014-12-03  0:32   ` Scott Wood
2014-12-03  7:53     ` Emil Medve
2014-12-03 19:42       ` Arnd Bergmann
2014-12-03 20:19         ` Emil Medve [this message]
2014-12-04  4:04         ` Scott Wood
2014-12-01 10:02 ` [PATCH v3 4/4] powerpc/mpc85xx: Add FSL QorIQ DPAA QMan " Emil Medve

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547F704B.5070400@Freescale.com \
    --to=emilian.medve@freescale$(echo .)com \
    --cc=Chunhe.Lan@Freescale$(echo .)com \
    --cc=Geoff.Thorpe@Freescale$(echo .)com \
    --cc=arnd@arndb$(echo .)de \
    --cc=devicetree@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=poonam.aggrwal@Freescale$(echo .)com \
    --cc=scottwood@Freescale$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox