From: Shuah Khan <shuahkh@osg•samsung.com>
To: Anshuman Khandual <khandual@linux•vnet.ibm.com>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
Cc: mikey@neuling•org, anton@samba•org
Subject: Re: [PATCH V2 11/12] selftests, powerpc: Add test for all DSCR sysfs interfaces
Date: Tue, 13 Jan 2015 08:24:34 -0700 [thread overview]
Message-ID: <54B538B2.8030204@osg.samsung.com> (raw)
In-Reply-To: <1421144560-15901-12-git-send-email-khandual@linux.vnet.ibm.com>
On 01/13/2015 03:22 AM, Anshuman Khandual wrote:
> This test continuously updates the system wide DSCR default value
> in the sysfs interface and makes sure that the same is reflected
> across all the sysfs interfaces for each individual CPUs present
> on the system.
>
> Signed-off-by: Anshuman Khandual <khandual@linux•vnet.ibm.com>
> ---
> tools/testing/selftests/powerpc/dscr/Makefile | 3 +-
> .../selftests/powerpc/dscr/dscr_sysfs_test.c | 89 ++++++++++++++++++++++
> 2 files changed, 91 insertions(+), 1 deletion(-)
> create mode 100644 tools/testing/selftests/powerpc/dscr/dscr_sysfs_test.c
>
> diff --git a/tools/testing/selftests/powerpc/dscr/Makefile b/tools/testing/selftests/powerpc/dscr/Makefile
> index 4e84309..fada526 100644
> --- a/tools/testing/selftests/powerpc/dscr/Makefile
> +++ b/tools/testing/selftests/powerpc/dscr/Makefile
> @@ -1,5 +1,6 @@
> PROGS := dscr_default_test dscr_explicit_test dscr_user_test \
> - dscr_inherit_test dscr_inherit_exec_test
> + dscr_inherit_test dscr_inherit_exec_test \
> + dscr_sysfs_test
>
> CFLAGS := $(CFLAGS) -lpthread
>
> diff --git a/tools/testing/selftests/powerpc/dscr/dscr_sysfs_test.c b/tools/testing/selftests/powerpc/dscr/dscr_sysfs_test.c
> new file mode 100644
> index 0000000..3d11439
> --- /dev/null
> +++ b/tools/testing/selftests/powerpc/dscr/dscr_sysfs_test.c
> @@ -0,0 +1,89 @@
> +/*
> + * POWER Data Stream Control Register (DSCR) sysfs interface test
> + *
> + * This test updates to system wide DSCR default through the sysfs interface
> + * and then verifies that all the CPU specific DSCR defaults are updated as
> + * well verified from their sysfs interfaces.
> + *
> + * Copyright (C) 2015 Anshuman Khandual <khandual@linux•vnet.ibm.com>, IBM
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version
> + * 2 of the License, or (at your option) any later version.
> + */
> +#include "dscr.h"
> +
> +static int check_cpu_dscr_default(char *file, unsigned long val)
> +{
> + char buf[10];
> + int fd, rc;
> +
> + fd = open(file, O_RDWR);
> + if (fd == -1) {
> + perror("open() failed\n");
> + return 1;
> + }
> +
> + rc = read(fd, buf, sizeof(buf));
> + if (rc == -1) {
> + perror("read() failed\n");
> + return 1;
> + }
> + close(fd);
> +
> + buf[rc] = '\0';
> + if (strtol(buf, NULL, 16) != val) {
> + printf("DSCR match failed: %ld (system) %ld (cpu)\n",
> + val, strtol(buf, NULL, 16));
> + return 1;
> + }
> + return 0;
> +}
> +
> +static int check_all_cpu_dscr_defaults(unsigned long val)
> +{
> + DIR *sysfs;
> + struct dirent *dp;
> + char file[LEN_MAX];
> +
> + sysfs = opendir(CPU_PATH);
> + if (!sysfs) {
> + perror("opendir() failed\n");
> + return 1;
> + }
> +
> + while ((dp = readdir(sysfs))) {
> + if (!(dp->d_type & DT_DIR))
> + continue;
> + if (!strcmp(dp->d_name, "cpuidle"))
> + continue;
> + if (!strstr(dp->d_name, "cpu"))
> + continue;
> +
> + sprintf(file, "%s%s/dscr", CPU_PATH, dp->d_name);
> + if (check_cpu_dscr_default(file, val))
> + return 1;
> + }
> + closedir(sysfs);
> + return 0;
> +}
> +
> +int test_body(void)
> +{
> + int i, j;
> +
> + for (i = 0; i < COUNT; i++) {
> + for (j = 0; j < DSCR_MAX; j++) {
> + set_default_dscr(j);
> + if (check_all_cpu_dscr_defaults(j))
> + return 1;
> + }
> + }
> + return 0;
> +}
> +
> +int main(int argc, char *argv[])
> +{
> + return test_harness(test_body, "dscr_sysfs_test");
> +}
>
Could you please add a .gitignore for powerpc targets as we
discussed earlier. It can be separate patch.
Also, I would like to see the test results reports using
kselftest.h - it can be separate patch in the interest of
getting tests in.
Acked-by: Shuah Khan <shuahkh@osg•samsung.com>
Please take this through powerpc maintainer git.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg•samsung.com | (970) 217-8978
next prev parent reply other threads:[~2015-01-13 15:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 10:22 [PATCH V2 00/12] POWER DSCR fixes, improvements, docs and tests Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 01/12] powerpc: Fix handling of DSCR related facility unavailable exception Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 02/12] powerpc, process: Remove the unused extern dscr_default Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 03/12] powerpc, offset: Change PACA_DSCR to PACA_DSCR_DEFAULT Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 04/12] powerpc, dscr: Added some in-code documentation Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 05/12] documentation, powerpc: Add documentation for DSCR support Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 06/12] selftests, powerpc: Add test for system wide DSCR default Anshuman Khandual
2015-01-13 15:22 ` Shuah Khan
2015-01-13 23:44 ` Michael Ellerman
2015-01-20 21:40 ` Dave Jones
2015-01-21 6:51 ` Michael Ellerman
2015-03-27 12:01 ` [V2, " Michael Ellerman
2015-04-09 10:31 ` Anshuman Khandual
2015-04-09 12:38 ` Anshuman Khandual
2015-01-13 10:22 ` [PATCH V2 07/12] selftests, powerpc: Add test for explicitly changing DSCR value Anshuman Khandual
2015-01-13 15:23 ` Shuah Khan
2015-01-13 10:22 ` [PATCH V2 08/12] selftests, powerpc: Add test for DSCR SPR numbers Anshuman Khandual
2015-01-13 15:23 ` Shuah Khan
2015-01-13 10:22 ` [PATCH V2 09/12] selftests, powerpc: Add test for DSCR value inheritence across fork Anshuman Khandual
2015-01-13 15:24 ` Shuah Khan
2015-01-13 10:22 ` [PATCH V2 10/12] selftests, powerpc: Add test for DSCR inheritence across fork & exec Anshuman Khandual
2015-01-13 15:24 ` Shuah Khan
2015-01-13 10:22 ` [PATCH V2 11/12] selftests, powerpc: Add test for all DSCR sysfs interfaces Anshuman Khandual
2015-01-13 15:24 ` Shuah Khan [this message]
2015-01-13 10:22 ` [PATCH V2 12/12] selftests, powerpc: Add thread based stress test for " Anshuman Khandual
2015-01-13 15:24 ` Shuah Khan
2015-02-04 8:21 ` [PATCH V2 00/12] POWER DSCR fixes, improvements, docs and tests Anshuman Khandual
2015-02-04 8:36 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B538B2.8030204@osg.samsung.com \
--to=shuahkh@osg$(echo .)samsung.com \
--cc=anton@samba$(echo .)org \
--cc=khandual@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mikey@neuling$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox