public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Yijing Wang <wangyijing@huawei•com>
To: Rob Herring <robherring2@gmail•com>
Cc: linux-ia64@vger•kernel.org,
	"linux-pci@vger•kernel.org" <linux-pci@vger•kernel.org>,
	Guan Xuetao <gxt@mprc•pku.edu.cn>,
	Russell King <linux@arm•linux.org.uk>,
	"x86@kernel•org" <x86@kernel•org>,
	Geert Uytterhoeven <geert@linux-m68k•org>,
	Arnd Bergmann <arnd@arndb•de>,
	Marc Zyngier <marc.zyngier@arm•com>,
	Rusty Russell <rusty@rustcorp•com.au>,
	linux-m68k@lists•linux-m68k.org,
	Bjorn Helgaas <bhelgaas@google•com>,
	Thomas Gleixner <tglx@linutronix•de>,
	Yinghai Lu <yinghai@kernel•org>,
	"linux-arm-kernel@lists•infradead.org"
	<linux-arm-kernel@lists•infradead.org>,
	Liviu Dudau <liviu@dudau•co.uk>, Tony Luck <tony.luck@intel•com>,
	"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
	Jiang Liu <jiang.liu@linux•intel.com>,
	linux-alpha@vger•kernel.org,
	linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
	"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH v5 16/29] powerpc/pci: Use pci_scan_host_bridge() for simplicity
Date: Mon, 9 Mar 2015 10:47:41 +0800	[thread overview]
Message-ID: <54FD09CD.6010306@huawei.com> (raw)
In-Reply-To: <CAL_JsqJqpbTThfm2yctHr-gyySyxsJT3HS8rxm6oY+ZYVT5vvQ@mail.gmail.com>

On 2015/3/6 22:19, Rob Herring wrote:
> On Fri, Mar 6, 2015 at 3:33 AM, Yijing Wang <wangyijing@huawei•com> wrote:
>> Now we could use pci_scan_host_bridge() to scan
>> pci buses, provide powerpc specific pci_host_bridge_ops.
>>
>> Suggested-by: Arnd Bergmann <arnd@arndb•de>
>> Signed-off-by: Yijing Wang <wangyijing@huawei•com>
>> CC: Benjamin Herrenschmidt <benh@kernel•crashing.org>
>> CC: linuxppc-dev@lists•ozlabs.org
>> Signed-off-by: Bjorn Helgaas <bhelgaas@google•com>
>> ---
>>  arch/powerpc/include/asm/machdep.h       |    2 +-
>>  arch/powerpc/kernel/pci-common.c         |   63 ++++++++++++++++++------------
>>  arch/powerpc/platforms/pseries/pci.c     |    8 ++--
>>  arch/powerpc/platforms/pseries/pseries.h |    2 +-
>>  4 files changed, 44 insertions(+), 31 deletions(-)
>>
>> diff --git a/arch/powerpc/include/asm/machdep.h b/arch/powerpc/include/asm/machdep.h
>> index 8e7f2a8..b811d12 100644
>> --- a/arch/powerpc/include/asm/machdep.h
>> +++ b/arch/powerpc/include/asm/machdep.h
>> @@ -129,7 +129,7 @@ struct machdep_calls {
>>         void            (*pcibios_fixup)(void);
>>         int             (*pci_probe_mode)(struct pci_bus *);
>>         void            (*pci_irq_fixup)(struct pci_dev *dev);
>> -       int             (*pcibios_set_root_bus_speed)(struct pci_host_bridge
>> +       void            (*pcibios_set_root_bus_speed)(struct pci_host_bridge
>>                                 *bridge);
> 
> Shouldn't this be part of patch 15?

Hi Rob, I didn't merge this to patch 15 for building happy for patch 15.

> 
> Rob
> 
> .
> 


-- 
Thanks!
Yijing

      reply	other threads:[~2015-03-09  2:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1425634426-437-1-git-send-email-wangyijing@huawei.com>
2015-03-06  9:33 ` [PATCH v5 06/29] PCI: Pass PCI domain number combined with root bus number Yijing Wang
2015-03-06  9:33 ` [PATCH v5 15/29] powerpc/pci: Rename pcibios_root_bridge_prepare() Yijing Wang
2015-03-06  9:33 ` [PATCH v5 16/29] powerpc/pci: Use pci_scan_host_bridge() for simplicity Yijing Wang
2015-03-06 14:19   ` Rob Herring
2015-03-09  2:47     ` Yijing Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FD09CD.6010306@huawei.com \
    --to=wangyijing@huawei$(echo .)com \
    --cc=arnd@arndb$(echo .)de \
    --cc=bhelgaas@google$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=geert@linux-m68k$(echo .)org \
    --cc=gxt@mprc$(echo .)pku.edu.cn \
    --cc=jiang.liu@linux$(echo .)intel.com \
    --cc=linux-alpha@vger$(echo .)kernel.org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-ia64@vger$(echo .)kernel.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-m68k@lists$(echo .)linux-m68k.org \
    --cc=linux-pci@vger$(echo .)kernel.org \
    --cc=linux@arm$(echo .)linux.org.uk \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=liviu@dudau$(echo .)co.uk \
    --cc=marc.zyngier@arm$(echo .)com \
    --cc=robherring2@gmail$(echo .)com \
    --cc=rusty@rustcorp$(echo .)com.au \
    --cc=tglx@linutronix$(echo .)de \
    --cc=tony.luck@intel$(echo .)com \
    --cc=x86@kernel$(echo .)org \
    --cc=yinghai@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox